Skip to content

fix: authentication adapter app ID validation may be circumvented #8186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mtrezza
Copy link
Member

@mtrezza mtrezza commented Sep 20, 2022

@parse-github-assistant
Copy link

parse-github-assistant bot commented Sep 20, 2022

Thanks for opening this pull request!

  • ❌ Please edit your post and use the provided template when creating a new pull request. This helps everyone to understand your post better and asks for essential information to quicker review the pull request.

@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 93.82% // Head: 84.11% // Decreases project coverage by -9.70% ⚠️

Coverage data is based on head (b1dc796) compared to base (8580a52).
Patch coverage: 95.94% of modified lines in pull request are covered.

Additional details and impacted files
@@                Coverage Diff                @@
##           release-4.x.x    #8186      +/-   ##
=================================================
- Coverage          93.82%   84.11%   -9.71%     
=================================================
  Files                170      170              
  Lines              12502    12528      +26     
=================================================
- Hits               11730    10538    -1192     
- Misses               772     1990    +1218     
Impacted Files Coverage Δ
src/Adapters/Auth/spotify.js 62.50% <60.00%> (-17.50%) ⬇️
src/Adapters/Auth/facebook.js 83.33% <80.00%> (-3.63%) ⬇️
src/Controllers/DatabaseController.js 95.17% <100.00%> (-0.04%) ⬇️
src/LiveQuery/ParseCloudCodePublisher.js 100.00% <100.00%> (ø)
src/LiveQuery/ParseLiveQueryServer.js 95.18% <100.00%> (+0.14%) ⬆️
src/RestQuery.js 95.60% <100.00%> (+0.08%) ⬆️
src/RestWrite.js 93.77% <100.00%> (+0.01%) ⬆️
src/Routers/FilesRouter.js 87.60% <100.00%> (+0.53%) ⬆️
...dapters/Storage/Postgres/PostgresStorageAdapter.js 2.42% <0.00%> (-93.52%) ⬇️
src/Adapters/Storage/Postgres/PostgresClient.js 6.66% <0.00%> (-80.00%) ⬇️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title fix: release-4.x.x fix: authentication adapter app ID validation may be circumvented Sep 20, 2022
@mtrezza mtrezza merged commit b3e7939 into parse-community:release-4.x.x Sep 20, 2022
parseplatformorg pushed a commit that referenced this pull request Sep 20, 2022
## [4.10.16](4.10.15...4.10.16) (2022-09-20)

### Bug Fixes

* authentication adapter app ID validation may be circumvented; this fixes a vulnerability that affects configurations which allow users to authenticate using the Parse Server authentication adapter for *Facebook* or *Spotify* and where the server-side authentication adapter configuration `appIds` is set as a string (e.g. `abc`) instead of an array of strings (e.g. `["abc"]`) ([GHSA-r657-33vp-gp22](GHSA-r657-33vp-gp22)) ([#8186](#8186)) ([b3e7939](b3e7939))
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 4.10.16

@parseplatformorg parseplatformorg added the state:released-4.x.x Released as LTS version label Sep 20, 2022
@parse-github-assistant
Copy link

The label state:released-4.x.x cannot be used here.

@parse-github-assistant parse-github-assistant bot removed the state:released-4.x.x Released as LTS version label Sep 20, 2022
@mtrezza mtrezza deleted the fix-release-4.x.x-gp22- branch September 20, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants