-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: allow master key to bypass email verification #8231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
Conversation
Thanks for opening this pull request!
|
Codecov ReportBase: 94.11% // Head: 93.96% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## alpha #8231 +/- ##
==========================================
- Coverage 94.11% 93.96% -0.16%
==========================================
Files 182 182
Lines 13770 13754 -16
==========================================
- Hits 12960 12924 -36
- Misses 810 830 +20
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Kindly comment when this is ready for review |
588b0f3
to
630d464
Compare
Ready for review @mtrezza |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please bring this up-to-date with the base branch?
Note for reviewers: this feature approach should be reviewed in context of #7144
@mtrezza Done |
How do you see #7144 in relation to your use case? Would that fully / partially / not at all address your requirements? |
@mtrezza There are multiple suggestions at #7144 . Let me know what you think. |
Thanks for this PR! Perhaps this would be more along the lines of #8218, a |
That would be possible as a temp. workaround, but:
The I think email verification needs some refinements. It's either on or off for all, not very practical and probably forces some developers to not use it even though it's an important spam block feature. Let's discuss in #7144 how a solution could look like. If we can find one that incorporates #7144 and #8230, we'd close 2 issues at once. And it could be a solution where the master key isn't necessary. |
New Pull Request Checklist
Issue Description
This PR allows the master key to bypass email verification.
Related issue: #8230
Approach
Modified RestWrite to avoid triggering the verification sequence and create a session token if the request was initiated by the master key and the request sets
emailVerified
to true.TODOs before merging