Skip to content

refactor: replace deprecated LRU cache methods #8266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2022
Merged

refactor: replace deprecated LRU cache methods #8266

merged 1 commit into from
Nov 1, 2022

Conversation

Moumouls
Copy link
Member

@Moumouls Moumouls commented Nov 1, 2022

New Pull Request Checklist

Issue Description

LRU .del() and .reset() are deprecated and generate a huge amount of warning logs.

Related issue: None

Approach

Use recommanded methods

TODOs before merging

  • A changelog entry is created automatically using the pull request title (do not manually add a changelog entry)

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title fix: LRU deprecations fix: lRU deprecations Nov 1, 2022
@parse-github-assistant
Copy link

parse-github-assistant bot commented Nov 1, 2022 •
edited
Loading

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Related issue: #123 in the PR description, so I can recognize it.

@Moumouls Moumouls requested a review from a team November 1, 2022 17:45
@mtrezza mtrezza changed the title fix: lRU deprecations refactor: replace deprecated LRU methods Nov 1, 2022
@mtrezza mtrezza changed the title refactor: replace deprecated LRU methods refactor: replace deprecated LRU cache methods Nov 1, 2022
mtrezza
mtrezza approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtrezza mtrezza merged commit e90a518 into parse-community:alpha Nov 1, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-alpha.1

@parseplatformorg parseplatformorg added the state:released-alpha Released as alpha version label Nov 10, 2022
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Jan 31, 2023
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 6.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 31, 2023
dblythy pushed a commit to dblythy/parse-server that referenced this pull request Feb 15, 2023
@Moumouls @dblythy
refactor: replace deprecated LRU cache methods (parse-community#8266)
81479e4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtrezza mtrezza mtrezza approved these changes

Assignees
No one assigned
Labels
state:released Released as stable version state:released-alpha Released as alpha version state:released-beta Released as beta version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moumouls @parseplatformorg @mtrezza