Skip to content

ci: Fix failing Node 14 workflow #8379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 6, 2023

New Pull Request Checklist

Issue Description

Currently the CI fails on Node 14. When we updated to lockfile v2, there were some manual changes to make it compatible with Node 14. These changes get reverted whenever npm i is ran in another PR.

Closes: n/a

Approach

Adds script to allow npm ci to work on node 14. Can be removed once node 14 is no longer supported.

TODOs before merging

  • Add tests

@parse-github-assistant
Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title ci: support node 14 ci: Support node 14 Jan 6, 2023
@parse-github-assistant
Copy link

parse-github-assistant bot commented Jan 6, 2023

Thanks for opening this pull request!

  • ❌ Please link an issue that describes the reason for this pull request, otherwise your pull request will be closed. Make sure to write it as Closes: #123 in the PR description, so I can recognize it.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 94.04% // Head: 94.32% // Increases project coverage by +0.28% 🎉

Coverage data is based on head (9410b72) compared to base (b1bb1fc).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##            alpha    #8379      +/-   ##
==========================================
+ Coverage   94.04%   94.32%   +0.28%     
==========================================
  Files         181      181              
  Lines       14266    14266              
==========================================
+ Hits        13416    13456      +40     
+ Misses        850      810      -40     
Impacted Files Coverage Δ
src/RestWrite.js 94.76% <0.00%> (ø)
src/LiveQuery/ParseLiveQueryServer.js 95.85% <0.00%> (+0.21%) ⬆️
src/ParseServer.js 92.16% <0.00%> (+0.46%) ⬆️
src/Adapters/Files/GridFSBucketAdapter.js 94.20% <0.00%> (+0.72%) ⬆️
src/LiveQuery/ParseCloudCodePublisher.js 100.00% <0.00%> (+15.78%) ⬆️
src/Adapters/Cache/RedisCacheAdapter.js 91.30% <0.00%> (+73.91%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mtrezza mtrezza changed the title ci: Support node 14 ci: Fix failing Node 14 workflow Jan 6, 2023
@mtrezza
Copy link
Member

mtrezza commented Jan 8, 2023

@dblythy is it fine if we close this PR in favor of #8381, or do you have any concerns regarding the approach?

@dblythy
Copy link
Member Author

dblythy commented Jan 8, 2023

Sounds good!

@dblythy dblythy closed this Jan 8, 2023
@dblythy dblythy deleted the fix-node-14 branch January 10, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants