-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
feat: RequestContextMiddleware and config in hooks #8480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: alpha
Are you sure you want to change the base?
feat: RequestContextMiddleware and config in hooks #8480
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
I will reformat the title to use the proper commit message syntax. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## alpha #8480 +/- ##
==========================================
- Coverage 94.33% 94.15% -0.18%
==========================================
Files 183 183
Lines 14515 14526 +11
==========================================
- Hits 13692 13677 -15
- Misses 823 849 +26
... and 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
@Moumouls Any suggestion what we should do with this PR? Does this require more development? If so; I'd change this to draft, otherwise maybe we can get this merged? |
Hi @mtrezza we don't need more development here. This PR is to allow developers to mutate the config using a provided middleware. It's super useful, when you need to inject globally on each request (after the Parse middleware) some providers, for monitoring, feature flags, based on the current user/ parse config. Then the injected prop will be available in each hooks, GQL API |
And no breaking change, right? |
Pull Request
Issue
Closes: #8479 8479
Approach
Add a middleware option and add config to hooks
Tasks