Skip to content

fix: Inaccurate table total row count for PostgreSQL #8511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2023
Merged

fix: Inaccurate table total row count for PostgreSQL #8511

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a01ee40
fix: showing wrong total count for tables
patelmilanun Apr 14, 2023
a5d9c4b
Merge branch 'alpha' into count-fix
mtrezza May 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Adapters/Storage/Postgres/PostgresStorageAdapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2040,7 +2040,7 @@ export class PostgresStorageAdapter implements StorageAdapter {
if (where.pattern.length > 0 || !estimate) {
qs = `SELECT count(*) FROM $1:name ${wherePattern}`;
} else {
qs = 'SELECT reltuples AS approximate_row_count FROM pg_class WHERE relname = $1';
qs = 'SELECT n_live_tup AS approximate_row_count FROM pg_stat_all_tables WHERE relname = $1;';
}

return this._client
Expand Down