Proposal for aggregation queries #3
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flovilmart
approved these changes
Nov 24, 2016
flovilmart
approved these changes
Nov 24, 2016
| Additionally, the presence of this parameter should modify the queries as follows: | ||
|
|
||
| - In MongoDB, execute the `.distinct()` method instead of the usual `find` query | ||
| - In Postgres, use `DISTINCT(fieldname)` instead of the usual list of field names in the `find` query |
There was a problem hiding this comment.
this implementation seems to be trivial :)
There was a problem hiding this comment.
hopefully there won't be any hidden issues :)
I just realized I haven't considered what happens if both keys and distinct are set. And what if include is set?
There was a problem hiding this comment.
Just added a suggestion in the proposal to handle the presence of these parameters.
kulshekhar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.