Skip to content

fix: datasets API edgecase where stream is not hottiered #1252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025
Merged

fix: datasets API edgecase where stream is not hottiered #1252

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/prism/logstream/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ use chrono::Utc;
use http::StatusCode;
use serde::{Deserialize, Serialize};
use serde_json::{json, Value};
use tracing::{debug, warn};
use tracing::{debug, error, warn};

use crate::{
handlers::http::{
Expand All @@ -45,6 +45,7 @@ use crate::{
arrow::record_batches_to_json,
time::{TimeParseError, TimeRange},
},
validator::error::HotTierValidationError,
LOCK_EXPECT,
};

Expand Down Expand Up @@ -273,10 +274,13 @@ impl PrismDatasetRequest {
} = get_prism_logstream_info(stream).await?;

let hottier = match HotTierManager::global() {
Some(hot_tier_manager) => {
let stats = hot_tier_manager.get_hot_tier(stream).await?;
Some(stats)
}
Some(manager) => match manager.get_hot_tier(stream).await {
Ok(stats) => Some(stats),
Err(HotTierError::HotTierValidationError(
HotTierValidationError::NotFound(_),
)) => None,
Err(err) => return Err(err.into()),
},
_ => None,
};
let records = CountsRequest {
Expand Down
Loading