Skip to content

Conversation

parmesant
Copy link
Contributor

@parmesant parmesant commented Aug 29, 2025

Fixes #XXXX.

Description


This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

Summary by CodeRabbit

  • New Features
    • Alert summaries now include a “lastTriggeredAt” timestamp when available, showing the most recent trigger time at a glance.
    • The field appears conditionally (only when data exists), preserving backward compatibility for existing integrations.
    • Enhances visibility for monitoring and triage without altering other alert summary fields or behaviors.

Copy link
Contributor

coderabbitai bot commented Aug 29, 2025

Walkthrough

Exposes an optional last trigger timestamp in alert summaries by inserting "lastTriggeredAt" into the summary map when last_triggered_at exists. No other logic or public API signatures are changed.

Changes

Cohort / File(s) Summary of Changes
Alert summary serialization
src/alerts/mod.rs
Adds conditional insertion of "lastTriggeredAt" (stringified) into alert summary map when last_triggered_at is present. No other behavior changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Caller
  participant Alert
  participant Summary as Summary Map

  Caller->>Alert: to_summary()
  activate Alert
  Alert->>Summary: insert base fields
  alt last_triggered_at is Some
    Alert->>Summary: insert "lastTriggeredAt" = timestamp.to_string()
  else None
    Note right of Alert: No "lastTriggeredAt" key added
  end
  Alert-->>Caller: Summary
  deactivate Alert
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

A whisk of time in alert’s log,
A tick, a tock, a subtle cog—
Now summaries whisper when they rang,
“LastTriggeredAt,” a gentle clang.
I thump with joy, review is light—
One hop, one field, all set right. 🐇⏱️

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbit in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbit in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbit gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbit read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbit help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbit ignore or @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbit summary or @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbit or @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/alerts/mod.rs (1)

679-685: Prefer RFC 3339 timestamp for API stability

Current to_string() yields a human format (e.g., "… UTC"). Consider RFC 3339 for machine-readability. If you adopt this here, mirror the change for "created" to avoid mixed formats in the same payload.

-                serde_json::Value::String(ts.to_string()),
+                serde_json::Value::String(ts.to_rfc3339()),
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between df2b378 and 82264bf.

📒 Files selected for processing (1)
  • src/alerts/mod.rs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Build Default aarch64-apple-darwin
  • GitHub Check: Quest Smoke and Load Tests for Distributed deployments
  • GitHub Check: coverage
  • GitHub Check: Quest Smoke and Load Tests for Standalone deployments
  • GitHub Check: Build Default x86_64-apple-darwin
  • GitHub Check: Build Default x86_64-pc-windows-msvc
  • GitHub Check: Build Default x86_64-unknown-linux-gnu
  • GitHub Check: Build Kafka aarch64-apple-darwin
  • GitHub Check: Build Kafka x86_64-unknown-linux-gnu
  • GitHub Check: Build Default aarch64-unknown-linux-gnu
🔇 Additional comments (2)
src/alerts/mod.rs (2)

679-685: LGTM: optional lastTriggeredAt added correctly

Conditional insert, key casing aligns with existing summary fields, and None is omitted like tags.


679-685: last_triggered_at assignment verified
Both update_state implementations in src/alerts/alert_types.rs set last_triggered_at = Some(Utc::now()) when transitioning to AlertState::Triggered; no further changes needed.

@nikhilsinhaparseable nikhilsinhaparseable merged commit f10b28a into parseablehq:main Aug 29, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants