chore: update Cargo.toml for release v2.4.3 #1436
Conversation
WalkthroughBump crate version and UI asset metadata in Cargo.toml; remove an empty exported Changes
Sequence Diagram(s)(Skipped — changes are localized refactors and a deleted empty type; no new control-flow worth diagramming.) Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches
🧪 Generate unit tests
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
Cargo.toml (1)
163-164: Consider migrating asset integrity from SHA‑1 to SHA‑256.SHA‑1 is weak for integrity/signing; prefer SHA‑256. Keep SHA‑1 for back‑compat short‑term if tooling expects it.
Apply this (plus corresponding build.rs support) when ready:
[package.metadata.parseable_ui] assets-url = "https://parseable-prism-build.s3.us-east-2.amazonaws.com/v2.4.3/build.zip" assets-sha1 = "c902c3be71886f0ea271b7f3caed4f5b20f0aeb7" +assets-sha256 = "<fill-with-SHA256-of-build.zip>"
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
Cargo.toml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: coverage
🔇 Additional comments (2)
Cargo.toml (2)
3-3: Version bump looks good; align release artifacts and tags.Please ensure the v2.4.3 tag, changelog entry, and any container/image versions are updated together.
163-164: Verify S3 UI asset exists and SHA‑1 before merge.File: Cargo.toml (lines 163–164)
assets-url = "https://parseable-prism-build.s3.us-east-2.amazonaws.com/v2.4.3/build.zip" assets-sha1 = "c902c3be71886f0ea271b7f3caed4f5b20f0aeb7"Automated check failed with "/bin/bash: line 9: !: command not found" and "ERROR: downloaded file is empty". Manually confirm the S3 object is reachable and that sha1(build.zip) == c902c3be71886f0ea271b7f3caed4f5b20f0aeb7 (curl -fSL -o build.zip && sha1sum build.zip).
nikhilsinhaparseable
dismissed
coderabbitai[bot]’s stale review
via
cf3cbb3
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
src/storage/s3.rs (1)
536-541: Multipart completion error is swallowed; aborts but returns Ok.Failure to complete should propagate; otherwise callers see success on a failed upload.
Apply:
- if let Err(err) = async_writer.complete().await { - error!("Failed to complete multipart upload. {:?}", err); - async_writer.abort().await?; - }; + if let Err(err) = async_writer.complete().await { + error!("Failed to complete multipart upload. {:?}", err); + if let Err(abort_err) = async_writer.abort().await { + error!("Failed to abort multipart upload: {:?}", abort_err); + } + return Err(err.into()); + };src/storage/azure_blob.rs (1)
371-375: Multipart completion error is swallowed; aborts but returns Ok.Mirror GCS behavior and propagate the error after abort.
- if let Err(err) = async_writer.complete().await { - error!("Failed to complete multipart upload. {:?}", err); - async_writer.abort().await?; - }; + if let Err(err) = async_writer.complete().await { + error!("Failed to complete multipart upload. {:?}", err); + if let Err(abort_err) = async_writer.abort().await { + error!("Failed to abort multipart upload: {:?}", abort_err); + } + return Err(err.into()); + };
🧹 Nitpick comments (2)
src/storage/localfs.rs (2)
221-222: Trait object boxing cleanup is fine; consider keeping signatures uniform across backends.Other backends omit the explicit 'static bound; keep one style for consistency.
253-258: Metrics status code logic looks inverted.You emit "400" when results are non-empty and "200" when empty. For successful execution, report 200 regardless of count.
- // maybe change the return code - let status = if res.is_empty() { "200" } else { "400" }; + // success path + let status = "200";
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
Cargo.toml(2 hunks)src/static_schema.rs(0 hunks)src/storage/azure_blob.rs(1 hunks)src/storage/gcs.rs(1 hunks)src/storage/localfs.rs(1 hunks)src/storage/s3.rs(1 hunks)
💤 Files with no reviewable changes (1)
- src/static_schema.rs
🚧 Files skipped from review as they are similar to previous changes (1)
- Cargo.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Build Default x86_64-unknown-linux-gnu
- GitHub Check: Build Default aarch64-apple-darwin
- GitHub Check: Build Default x86_64-pc-windows-msvc
- GitHub Check: Build Default x86_64-apple-darwin
- GitHub Check: Build Kafka aarch64-apple-darwin
- GitHub Check: Build Kafka x86_64-unknown-linux-gnu
- GitHub Check: Build Default aarch64-unknown-linux-gnu
- GitHub Check: Quest Smoke and Load Tests for Distributed deployments
- GitHub Check: coverage
- GitHub Check: Quest Smoke and Load Tests for Standalone deployments
🔇 Additional comments (3)
src/storage/azure_blob.rs (1)
348-351: Approve: is_multiple_of OK (MSRV = 1.88.0).
Cargo.toml declares rust-version = "1.88.0", so the .is_multiple_of usage is supported; keep as-is.src/storage/s3.rs (1)
513-516: Remove fallback: MSRV 1.88.0 supportsusize::is_multiple_of.Our Cargo.toml sets
rust-version = "1.88.0", andusize::is_multiple_ofhas been stable since Rust 1.0.0 (const-stable in 1.32.0) (doc.rust-lang.org)src/storage/gcs.rs (1)
327-330: MSRV confirmed — usize::is_multiple_of is supported (stabilized in Rust 1.87).Cargo.toml sets rust-version = "1.88.0" and workflows install the stable toolchain, so this use is supported. (doc.rust-lang.org)
nikhilsinhaparseable
merged commit b5d85ef
into
parseablehq:main
Summary by CodeRabbit