Skip to content

feat(patternlabjs): Remove build callback #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 15, 2017
Merged

feat(patternlabjs): Remove build callback #753

merged 1 commit into from
Nov 15, 2017

Conversation

bmuenzenmeyer
Copy link
Member

Addresses #751

Summary of changes:

Removes the first parameter (a callback) in the build and patternsonly methods, as they return promises anyway

@coveralls
Copy link

coveralls commented Nov 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 72.583% when pulling d2f346d on 751-remove-build-callback into 50474de on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit 5f7a3f1 into dev Nov 15, 2017
@bmuenzenmeyer bmuenzenmeyer deleted the 751-remove-build-callback branch November 15, 2017 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmuenzenmeyer @coveralls