Skip to content

Pattern param rework #771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jan 15, 2018
Merged

Pattern param rework #771

merged 19 commits into from
Jan 15, 2018

Conversation

bmuenzenmeyer
Copy link
Member

Addresses #769 Rework Pattern Parameter Algorithm

Summary of changes:

  • Found pattern parameters are no longer rendered immediately. Not sure why I ever thought that was a good idea. Now, they are evaluated and replace their value or section in the pattern's extendedTemplate
  • All tests are passing - excepting two which I commented out.
  • I expect that list_item_hunter should be similarly refactored.

bmuenzenmeyer and others added 19 commits January 12, 2018 06:13
@bmuenzenmeyer
checking in some sloppy wip
672ea88
@bmuenzenmeyer
chore(logs): Clean up logs a bit
3fe17e5
@bmuenzenmeyer
refactor(processRecursive): Use getPartial
c706267
@bmuenzenmeyer
refactor(expandPartials): Use getPartial
1021702
@bmuenzenmeyer
refactor(get): Remove path normalize call
be3b3f7
@bmuenzenmeyer
refactor(parameter_hunter): replaceParameter helper. may still be bri…
d486abf 
…ttle
@bmuenzenmeyer
chore(lint): Fix lint issues
6ea5eee
@bmuenzenmeyer
fix(parameter_hunter): Replace algorithm
f0be039
@bmuenzenmeyer
fix(unit tests): change verbose partial paths. not sure if this is a …
6fe9785 
…good idea.
@bmuenzenmeyer
fix(package): Remove unneeded dependency
438c6b1
@bmuenzenmeyer
refactor(unit tests): Commit WIP pattern parameter tests
e9d6c9e
@bmuenzenmeyer
feat(patternlab): Accept additional data during build as an option
3100402
@bmuenzenmeyer
chore(unit tests): WIP tests
5cc8703
@bmuenzenmeyer
fix(unit tests): Fix more tests
9f3c4c9
@bmuenzenmeyer
chore(unit tests): WIP
4072b61
@bmuenzenmeyer
fix(unit tests): Fix more tests. Since we no longer render, no need t…
c50484d 
…o look for escaped values
@bmuenzenmeyer
fix(replaceParameter): Support unescaped replacement
019c6c4
@bmuenzenmeyer
chore(unit tests): Test WIP and lint fixes
13dbeaa
@bmuenzenmeyer
fix(parameter_hunter): Consume styleModifiers again
2f84d9c
@bmuenzenmeyer bmuenzenmeyer self-assigned this Jan 15, 2018
@coveralls
Copy link

coveralls commented Jan 15, 2018 •
edited
Loading

Coverage Status

Coverage increased (+7.4%) to 71.349% when pulling 2f84d9c on pattern-param-rework into 578a9af on dev.

@bmuenzenmeyer bmuenzenmeyer merged commit 63117e2 into dev Jan 15, 2018
@bmuenzenmeyer bmuenzenmeyer deleted the pattern-param-rework branch January 15, 2018 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bmuenzenmeyer bmuenzenmeyer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmuenzenmeyer @coveralls