Skip to content

Add parsing of PL extra section in main project's composer.json #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aleksip opened this issue Apr 13, 2016 · 2 comments
Closed

Add parsing of PL extra section in main project's composer.json #15

aleksip opened this issue Apr 13, 2016 · 2 comments
Assignees

Comments

@aleksip
Copy link
Member

aleksip commented Apr 13, 2016

It seems that a possible Pattern Lab extra section in the main project's composer.json is not parsed apart from starterKitSuggestions when running composer create-project.

This would be a nice feature to have for setting config options in an edition's composer.json.

@dmolsen
Copy link
Member

dmolsen commented May 6, 2016

Config options can now be set in an edition's composer.json. This feature is supported in the feature-installupdate branch of the development edition and core. A couple of notes...

  • the config options from an edition's composer.json are applied after everything else has been installed. this way any option set by a package can be overridden on a per edition basis.
  • the override is done silently
  • i need to look at overriding options with arrays. this is a general issue with the composer.json config set-up. going to use a spin-off of sayings to test this.

@dmolsen
Copy link
Member

dmolsen commented May 14, 2016

Arrays should be handled. With no other other comments on the process I'm going to take this feature as done and will be implementing with the push of the feature-installupdate branch towards a release.

@dmolsen dmolsen closed this as completed May 14, 2016
EvanLovely added a commit that referenced this issue Oct 9, 2017
…ic-dir

Working solution to regenerate missing styleguideKit index.html in the public directory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants