Don't require very specific dependencies of upstream libraries #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @deviantintegral. I'm unfamiliar with this so I'll leave it to @dmolsen to explain the rationale and/or merge the pull request. Thanks! |
|
At the time I did it it was because it was the only way to have Composer load dependencies in some semblance of rational order. I even opened an issue about this with Composer. I'll merge your changes with a test branch tomorrow and see if newer versions of Composer addressed it. |
EvanLovely
added a commit
that referenced
this pull request
Oct 9, 2017
Replace possible dots in pattern names with dashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to integrate Patternlab with another code base, but the to-the-patch-version dependencies in composer.json totally break that.
There's a question about the same issue on the commit at 6bb7c7b - I've yet to find any answer as to why this was done in the first place.