Revert "chore(API docs): update header of angular-patternfly API Docs site" #608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dabeng I am reverting this because it messes up the styling of the components in the examples. The CSS is lengthy (I assume it comes from a less file somewhere) and uses '.showcase h3' and other such things. That selector is far too broad and should be limited only to the header (ie. .showcase > header h3). |
|
Does commit msg need to start with "chore(....)" |
dtaylor113
approved these changes
Sep 1, 2017
jeff-phillips-18
force-pushed
the
revert-556-new-header
branch
from
cbea108 to
d19d33b
Compare
|
Updated the commit wording |
|
@jeff-phillips-18 , could you tell me which the components showcase.css messes up? |
|
@dabeng I would have to reload it to find out. I know there are H3's and such that are affected. The gist of it is the .showcase selectors are broad and should be limited to the header, footer, etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #556
Related to #607
Fixes #607