pfModalOverlay: allow async validations while keeping modal open, demo maxlength validation

[dtaylor113]

Description

Fixes #755

Added the ability to return false for actionBtn function(s) to keep modal open. Allows app dev to click 'Save', show spinner & perform async validation, and if invalid display error msg, or if valid, programmatically close the modal:
Also demonstrated how to perform ng-maxlength validations.

Also fixes #757 (Broken Semantic Release)

PR Checklist

• Unit tests are included
• Screenshots are attached (if there are visual changes in the UI)
• A Designer (@beanh66) is assigned as a reviewer (if there are visual changes in the UI)
• A CSS rep (@cshinn) is assigned as a reviewer (if there are visual changes in the UI)

[beanh66]

@dtaylor113 This is working great! Wondering if we can adjust the visuals to match the PF "Errors and Validation" pattern.

[beanh66]

Following the Errors and Validation pattern would include an inline notification at the top with the specific field-level errors listed out by each field. Below is an example of what I mean:

[dtaylor113]

Hi @beanh66, ok, sounds good. The example here actually can have several error messages, how would that be displayed in the modal?

[beanh66]

The summary is just in the inline notification so I think that could stay the same...input is not valid, fix the errors, etc. Then the additional errors would be highlighted below. Does that make sense?

Something like this:

[dtaylor113]

@beanh66, ok, thanks, that makes sense. I'll work on it some more. I may create another Issue/PR for this additional work because it's not what this PR was directly addressing. -thanks

[dtaylor113]

I may create another Issue/PR for this additional work because it's not what this PR was directly addressing

...for the inline notification at the top that is, the field level help shouldn't be an issue for this PR. I need to figure out if the inline notification at the top should be baked into the component, or done via the app dev's supplied form.

[dtaylor113]

Hi @beanh66, updated the screenshot/video in this PR's description. PTAL -thanks!

[beanh66]

Thanks @dtaylor113 LGTM!

[dtaylor113]

@jeff-phillips-18, hoping you could take a look -thanks

[jeff-phillips-18]

Only concern would be an existing application returning false but not expecting the modal to remain open. Unlikely unless it is just happenstance. I think it's OK to assume that unlikelyhood is great enough to proceed.

[dtaylor113]

Yeah, I tend to agree that scenario is unlikely. If an app was returning false, I'm not sure why or what controller would be processing a true or false? The component executes the button actionFns and it wasn't expecting any return values.