Skip to content

docs(charts): Updates colors for charts page. #4448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 15, 2025

Conversation

edonehoo
Copy link
Collaborator

@edonehoo edonehoo commented Jan 24, 2025

Closes #4412

@edonehoo edonehoo marked this pull request as draft January 24, 2025 21:02
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 24, 2025

@edonehoo edonehoo linked an issue Feb 27, 2025 that may be closed by this pull request
@edonehoo
Copy link
Collaborator Author

wonder if we should consider combining this page with https://www.patternfly.org/charts/themes?

@edonehoo edonehoo marked this pull request as ready for review April 10, 2025 17:42
Copy link

@lboehling lboehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing, Erin! Love the visuals.

+1 to combining with the theme page. The design guidelines on the theme page are super limited anyways, and your new content does a great job explaining the color scales/multicolor themes!

Copy link
Contributor

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📈

@edonehoo
Copy link
Collaborator Author

opened a follow-up to combine the pages! patternfly/patternfly-react#11757

@nicolethoen nicolethoen merged commit 1670382 into patternfly:main Apr 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Colors for Charts page uses old color tokens Update colors for charts page
5 participants