Skip to content

Conversation

mfrances17
Copy link
Contributor

What: Closes #9921

Mostly icon changes, added some extra code to make it responsive in different screen sizes and to make it work with light/dark mode.

Additional issues:
None

@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 25, 2024

@andrew-ronaldson andrew-ronaldson self-requested a review January 25, 2024 22:02
Copy link
Collaborator

@andrew-ronaldson andrew-ronaldson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Great to have the light/dark switcher working on this too!

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of quick comments below. @edonehoo do you think it'd be worth adding a description to the basic example to call out that theme support has to be manually done by the consumer, rather than it being something built into the component?

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪

@edonehoo
Copy link
Contributor

Couple of quick comments below. @edonehoo do you think it'd be worth adding a description to the basic example to call out that theme support has to be manually done by the consumer, rather than it being something built into the component?

@thatblindgeye I think that makes sense here! wdyt about something simple like this?:

The brand component does not have any built-in theme support. If a brand should be dynamically styled, you must manually set up the necessary logic on your own.

This example adjusts styling as the PatternFly website is toggled between the light and dark theme.

Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the above comments LGTM!

@wise-king-sullyman wise-king-sullyman linked an issue Jan 31, 2024 that may be closed by this pull request
@mfrances17
Copy link
Contributor Author

@thatblindgeye I think that makes sense here! wdyt about something simple like this?:

The brand component does not have any built-in theme support. If a brand should be dynamically styled, you must manually set up the necessary logic on your own.
This example adjusts styling as the PatternFly website is toggled between the light and dark theme.

I added this, slight wording changes and placement... I added the blurb above the basic example under Examples because it applies to both examples.

Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tlabaj tlabaj merged commit f559843 into patternfly:v6 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consume core Penta updates: Brand
8 participants