Skip to content

feat(Page,Drawer): core bump and updates #10211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Mar 27, 2024
Merged

feat(Page,Drawer): core bump and updates #10211

merged 7 commits into from
Mar 27, 2024

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Mar 27, 2024 •
edited
Loading

What: Closes #10203

  • Added div around page-main for page-main-container
  • Replaced noBackground with primary for DrawerContent and separated into a new enum.
  • Updated layout custom CSS and md with core bump
  • Updated core ver to 107
  • Added temp fix for tokens parsing

@patternfly-build
Copy link
Contributor

patternfly-build commented Mar 27, 2024 •
edited
Loading

Preview: https://patternfly-react-pr-10211.surge.sh

A11y report: https://patternfly-react-pr-10211-a11y.surge.sh

wise-king-sullyman
wise-king-sullyman approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming it passes CI LGTM 🚀

tlabaj
tlabaj approved these changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@tlabaj tlabaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@mcoker mcoker mentioned this pull request Mar 27, 2024
Closed
@tlabaj tlabaj merged commit 8210248 into patternfly:v6 Mar 27, 2024
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

@kmcfaul kmcfaul linked an issue Mar 28, 2024 that may be closed by this pull request
Page - add container for main content area #10203
Closed
@evwilkin evwilkin mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wise-king-sullyman wise-king-sullyman wise-king-sullyman approved these changes

@mcoker mcoker mcoker approved these changes

@tlabaj tlabaj tlabaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page - add container for main content area
5 participants
@kmcfaul @patternfly-build @wise-king-sullyman @mcoker @tlabaj