chore(Button): updated Button component/element usage #10820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatblindgeye
requested review from
a team,
kmcfaul,
mcoker and
tlabaj
and removed request for
a team
thatblindgeye
commented
Jul 30, 2024
| /** Additional classes added to the drag button */ | ||
| className?: string; | ||
| /** Sets button type */ | ||
| type?: 'button' | 'submit' | 'reset'; |
There was a problem hiding this comment.
Was there a reason this prop is included on the DragButton? I'd imagine we would never want the DragButton to act as a "submit" or "reset" button. cc @kmcfaul
|
Preview: https://patternfly-react-pr-10820.surge.sh A11y report: https://patternfly-react-pr-10820-a11y.surge.sh |
thatblindgeye
changed the title
wise-king-sullyman
approved these changes
Aug 13, 2024
tlabaj
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Closes #10698
buttonelements to use our Button componentAdditional issues: