Skip to content

fix(LoginPage): updated markup for LoginMainHeader #10880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2024
+8 −8
Merged

fix(LoginPage): updated markup for LoginMainHeader #10880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react-core/src/components/LoginPage/LoginMainHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const LoginMainHeader: React.FunctionComponent<LoginMainHeaderProps> = ({
headerUtilities = null,
...props
}: LoginMainHeaderProps) => (
<header className={css(styles.loginMainHeader, className)} {...props}>
<div className={css(styles.loginMainHeader, className)} {...props}>
{title && (
<Title headingLevel="h2" size={TitleSizes['3xl']}>
{title}
Expand All @@ -33,6 +33,6 @@ export const LoginMainHeader: React.FunctionComponent<LoginMainHeaderProps> = ({
{subtitle && <p className={css(styles.loginMainHeaderDesc)}>{subtitle}</p>}
{headerUtilities && <div className={css(styles.loginMainHeaderUtilities)}>{headerUtilities}</div>}
{children}
</header>
</div>
);
LoginMainHeader.displayName = 'LoginMainHeader';
8 changes: 4 additions & 4 deletions ...react-core/src/components/LoginPage/__tests__/__snapshots__/LoginMainHeader.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,23 +2,23 @@

exports[`LoginMainHeader className is added to the root element 1`] = `
<DocumentFragment>
<header
<div
class="pf-v6-c-login__main-header extra-class"
/>
</DocumentFragment>
`;

exports[`LoginMainHeader renders with PatternFly Core styles 1`] = `
<DocumentFragment>
<header
<div
class="pf-v6-c-login__main-header"
/>
</DocumentFragment>
`;

exports[`LoginMainHeader title and subtitle are rendered correctly 1`] = `
<DocumentFragment>
<header
<div
class="pf-v6-c-login__main-header"
>
<h2
Expand All @@ -34,6 +34,6 @@ exports[`LoginMainHeader title and subtitle are rendered correctly 1`] = `
>
Use LDAP credentials
</p>
</header>
</div>
</DocumentFragment>
`;
4 changes: 2 additions & 2 deletions packages/react-core/src/components/LoginPage/__tests__/__snapshots__/LoginPage.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ exports[`check loginpage example against snapshot 1`] = `
<main
class="pf-v6-c-login__main"
>
<header
<div
class="pf-v6-c-login__main-header"
>
<h2
Expand All @@ -35,7 +35,7 @@ exports[`check loginpage example against snapshot 1`] = `
>
Log into your account
</h2>
</header>
</div>
<div
class="pf-v6-c-login__main-body"
/>
Expand Down
Loading