feat(CC-batch-1): added batch 1 #11827
Conversation
|
Preview: https://patternfly-react-pr-11827.surge.sh A11y report: https://patternfly-react-pr-11827-a11y.surge.sh |
mattnolting
changed the title
mattnolting
force-pushed
the
feat-CC-batch-1
branch
from
cd2fe95 to
dbf3c61
Compare
mattnolting
force-pushed
the
feat-CC-batch-1
branch
from
dbf3c61 to
9f6488f
Compare
| }, | ||
| example: (props) => ( | ||
| <AccordionItem isExpanded={props.isExpanded}> | ||
| <AccordionToggle>{props.toggleTextExpanded}</AccordionToggle> |
There was a problem hiding this comment.
The AccordionToggle should have an id="<your-id-here>" or something like that. id` is a required prop.
There was a problem hiding this comment.
I'd also add a comment here recommending they implement an onClick event to toggle the expanded state of this Accordion.
| // enum | ||
| isActive: figma.enum('State', { Active: true }), | ||
| isReadOnly: figma.enum('State', { 'Read only': true }), | ||
| isExpanded: figma.enum('State', { Expanded: true }), |
There was a problem hiding this comment.
is there a way in figma to make an expandable clipboardCopy variant? If so, then isExpanded can be passed, but also the variant needs to be 'expansion'
| ActionList, | ||
| 'https://www.figma.com/design/aEBBvq0J3EPXxHvv6WgDx9/PatternFly-6--Components-Test?node-id=6780-15839&m=dev', | ||
| { | ||
| props: { |
There was a problem hiding this comment.
Not sure if it's worth adding the isIconList prop here or if there is no distinction in figma. In React this boolean prop adds a class for icon-only lists that removes some additional padding.
Relates to: #11624
Included components:
Component tracker
Figma preview
Resources: