Skip to content

chore(Spinner): updated isSVG prop default value #8183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 10, 2022
Merged

chore(Spinner): updated isSVG prop default value #8183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0df4174
chore(Spinner): updated isSVG prop default value
wise-king-sullyman Oct 6, 2022
3d0960e
updated prop in example to meet a11y requirements
wise-king-sullyman Oct 7, 2022
7bc91c6
updated react-console snapshots
wise-king-sullyman Oct 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions ...onsole/src/components/AccessConsoles/__tests__/__snapshots__/AccessConsoles.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,22 +129,21 @@ exports[`AccessConsoles with preselected SerialConsole 1`] = `
<div
class="pf-c-empty-state__icon"
>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading..."
class="pf-c-spinner pf-m-xl"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
/>
<span
class="pf-c-spinner__lead-ball"
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
</svg>
</div>
<div
class="pf-c-empty-state__body"
Expand Down
21 changes: 10 additions & 11 deletions ...-console/src/components/SerialConsole/__tests__/__snapshots__/SerialConsole.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,22 +70,21 @@ exports[`SerialConsole in the LOADING state 1`] = `
<div
class="pf-c-empty-state__icon"
>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading..."
class="pf-c-spinner pf-m-xl"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
/>
<span
class="pf-c-spinner__lead-ball"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
</svg>
</div>
<div
class="pf-c-empty-state__body"
Expand Down
19 changes: 9 additions & 10 deletions .../react-console/src/components/VncConsole/__tests__/__snapshots__/VncConsole.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,21 @@ exports[`placeholder render test 1`] = `
<div
class="pf-c-empty-state__icon"
>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading..."
class="pf-c-spinner pf-m-xl"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
<span
class="pf-c-spinner__lead-ball"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
</svg>
</div>
<div
class="pf-c-empty-state__body"
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Backdrop/examples/BackdropSpinner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import { Backdrop, Spinner, Bullseye } from '@patternfly/react-core';
export const BackdropSpinner: React.FunctionComponent = () => (
<Backdrop>
<Bullseye>
<Spinner aria-label="Backdrop content" aria-valueText="Loading..." />
<Spinner aria-label="Backdrop content" aria-valuetext="Loading..." />
</Bullseye>
</Backdrop>
);
38 changes: 18 additions & 20 deletions packages/react-core/src/components/Button/__tests__/__snapshots__/Button.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,22 +180,21 @@ exports[`Button isLoading 1`] = `
<span
class="pf-c-button__progress"
>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading"
class="pf-c-spinner pf-m-md"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
/>
<span
class="pf-c-spinner__lead-ball"
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
</svg>
</span>
Loading Button
</button>
Expand All @@ -216,22 +215,21 @@ exports[`Button isLoading icon only 1`] = `
<span
class="pf-c-button__progress"
>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading"
class="pf-c-spinner pf-m-md"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
/>
<span
class="pf-c-spinner__lead-ball"
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
</svg>
</span>
<div>
ICON
Expand Down
2 changes: 1 addition & 1 deletion packages/react-core/src/components/Spinner/Spinner.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ export const Spinner: React.FunctionComponent<SpinnerProps> = ({
className = '',
size = 'xl',
'aria-valuetext': ariaValueText = 'Loading...',
isSVG = false,
isSVG = true,
diameter,
'aria-label': ariaLabel,
'aria-labelledBy': ariaLabelledBy,
Expand Down
6 changes: 6 additions & 0 deletions packages/react-core/src/components/Spinner/__tests__/Spinner.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,9 @@ test('extra large spinner', () => {
const { asFragment } = render(<Spinner size="xl" />);
expect(asFragment()).toMatchSnapshot();
});

test('non-SVG spinner', () => {
const { asFragment } = render(<Spinner isSVG={false} />)

expect(asFragment()).toMatchSnapshot();
})
98 changes: 57 additions & 41 deletions packages/react-core/src/components/Spinner/__tests__/__snapshots__/Spinner.test.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,68 +2,65 @@

exports[`extra large spinner 1`] = `
<DocumentFragment>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading..."
class="pf-c-spinner pf-m-xl"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
<span
class="pf-c-spinner__lead-ball"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
</svg>
</DocumentFragment>
`;

exports[`large spinner 1`] = `
<DocumentFragment>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading..."
class="pf-c-spinner pf-m-lg"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
<span
class="pf-c-spinner__lead-ball"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
</svg>
</DocumentFragment>
`;

exports[`medium spinner 1`] = `
<DocumentFragment>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading..."
class="pf-c-spinner pf-m-md"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
/>
<span
class="pf-c-spinner__lead-ball"
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
</svg>
</DocumentFragment>
`;

exports[`simple spinner 1`] = `
exports[`non-SVG spinner 1`] = `
<DocumentFragment>
<span
aria-label="Contents"
Expand All @@ -84,23 +81,42 @@ exports[`simple spinner 1`] = `
</DocumentFragment>
`;

exports[`simple spinner 1`] = `
<DocumentFragment>
<svg
aria-label="Contents"
aria-valuetext="Loading..."
class="pf-c-spinner pf-m-xl"
role="progressbar"
viewBox="0 0 100 100"
>
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
</svg>
</DocumentFragment>
`;

exports[`small spinner 1`] = `
<DocumentFragment>
<span
<svg
aria-label="Contents"
aria-valuetext="Loading..."
class="pf-c-spinner pf-m-sm"
role="progressbar"
viewBox="0 0 100 100"
>
<span
class="pf-c-spinner__clipper"
<circle
class="pf-c-spinner__path"
cx="50"
cy="50"
fill="none"
r="45"
/>
<span
class="pf-c-spinner__lead-ball"
/>
<span
class="pf-c-spinner__tail-ball"
/>
</span>
</svg>
</DocumentFragment>
`;