Skip to content

chore(Tooltip) remove deprecated props #8231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 20, 2022
Merged

chore(Tooltip) remove deprecated props #8231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7702c42
chore(Tooltip) remove deprecated props
Dominik-Petrik Oct 14, 2022
0cd4fc6
fix demo
Dominik-Petrik Oct 14, 2022
a5fee55
remove deprecated test from demo
Dominik-Petrik Oct 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 0 additions & 19 deletions packages/react-core/src/components/Tooltip/Tooltip.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import { KeyTypes } from '../../helpers/constants';
import tooltipMaxWidth from '@patternfly/react-tokens/dist/esm/c_tooltip_MaxWidth';
import { ReactElement } from 'react';
import { Popper, getOpacityTransition } from '../../helpers/Popper/Popper';
import { Props as TippyProps } from '../../helpers/Popper/DeprecatedTippyTypes';

export enum TooltipPosition {
auto = 'auto',
Expand Down Expand Up @@ -132,12 +131,6 @@ export interface TooltipProps extends Omit<React.HTMLProps<HTMLDivElement>, 'con
id?: string;
/** CSS fade transition animation duration */
animationDuration?: number;
/** @deprecated - no longer used. if you want to constrain the popper to a specific element use the appendTo prop instead */
boundary?: 'scrollParent' | 'window' | 'viewport' | HTMLElement;
/** @deprecated - no longer used */
isAppLauncher?: boolean;
/** @deprecated - no longer used */
tippyProps?: Partial<TippyProps>;
/** @beta Opt-in for updated popper that does not use findDOMNode. */
removeFindDomNode?: boolean;
}
Expand Down Expand Up @@ -167,21 +160,9 @@ export const Tooltip: React.FunctionComponent<TooltipProps> = ({
animationDuration = 300,
reference,
'aria-live': ariaLive = reference ? 'polite' : 'off',
boundary,
isAppLauncher,
tippyProps,
removeFindDomNode = false,
...rest
}: TooltipProps) => {
if (process.env.NODE_ENV !== 'production') {
boundary !== undefined &&
console.warn(
'The Tooltip boundary prop has been deprecated. If you want to constrain the popper to a specific element use the appendTo prop instead.'
);
isAppLauncher !== undefined &&
console.warn('The Tooltip isAppLauncher prop has been deprecated and is no longer used.');
tippyProps !== undefined && console.warn('The Tooltip tippyProps prop has been deprecated and is no longer used.');
}
// could make this a prop in the future (true | false | 'toggle')
const hideOnClick = true;
const triggerOnMouseenter = trigger.includes('mouseenter');
Expand Down
3 changes: 0 additions & 3 deletions packages/react-integration/demo-app-ts/src/components/demos/TooltipDemo/TooltipDemo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ export class TooltipDemo extends Component {
return (
<div>
<Tooltip content={this.myTooltipProps.content}>{this.myTooltipProps.children}</Tooltip>
<Tooltip content="test deprecated props" tippyProps={{ duration: 0, delay: 0 }} isAppLauncher>
<button>Trigger</button>
</Tooltip>
<div>
<button ref={this.tooltipRef} id="tooltip-ref">
Tooltip attached via react ref
Expand Down