Skip to content

Conversation

kmcfaul
Copy link
Contributor

@kmcfaul kmcfaul commented Feb 6, 2023

What: Closes #4665

Adds logic to component type of Masthead and PageHeader. If an href is passed, the component type will be an anchor. If an onClick is passed, the type will be a button. Otherwise the type will be a span.

@patternfly-build
Copy link
Contributor

patternfly-build commented Feb 6, 2023

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we likely need a codemod to either warn about this update to the default component type in these cases, or just update the component passed to 'a' to prevent breaking changes? Would you mind at least opening the code mod issue to track that (or double check that one already exist and link it here?)

@kmcfaul
Copy link
Contributor Author

kmcfaul commented Feb 7, 2023

@nicolethoen Opened patternfly/pf-codemods#242
Will probably also try to get it in as well.

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Just a couple of comments.

Copy link
Contributor

@mcoker mcoker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L🚀TM!

@nicolethoen nicolethoen linked an issue Feb 9, 2023 that may be closed by this pull request
@tlabaj tlabaj merged commit c78e980 into patternfly:v5 Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Masthead: default element for MastheadBrand
7 participants