-
Notifications
You must be signed in to change notification settings - Fork 370
feat(Masthead, PageHeader): update component logic #8655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview: https://patternfly-react-pr-8655.surge.sh A11y report: https://patternfly-react-pr-8655-a11y.surge.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we likely need a codemod to either warn about this update to the default component type in these cases, or just update the component passed to 'a' to prevent breaking changes? Would you mind at least opening the code mod issue to track that (or double check that one already exist and link it here?)
@nicolethoen Opened patternfly/pf-codemods#242 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Just a couple of comments.
b22ce67
to
55e1bf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L🚀TM!
What: Closes #4665
Adds logic to component type of Masthead and PageHeader. If an
href
is passed, the component type will be an anchor. If anonClick
is passed, the type will be a button. Otherwise the type will be a span.