feat(react-dropzone): updated to latest version #216
Conversation
|
|
||
| ### react-dropzone-warn-upgrade [(#7926)](// https://github.com/patternfly/patternfly-react/pull/7926) | ||
|
|
||
| The `react-dropzone` dependency used with FileUpload, MultipleFileUpload, and CodeEditor has been updated from version 9 to version 14. |
There was a problem hiding this comment.
What might a consumer need to do with this change?
There was a problem hiding this comment.
From the PR itself, other than updating the version it looks like there were some type updates. Other than possibly mentioning those in the warning message, we could just state that the version bump may require additional breaking changes to be made (though it's a bit generic)
There was a problem hiding this comment.
Though part of that may be resolved with #142
There was a problem hiding this comment.
Hm, I wonder if this and a PR for #142 are both needed 🤔
There was a problem hiding this comment.
right... i wonder if the language from this can be merged into 142 (if we still want to talk about version numbers)
There was a problem hiding this comment.
We could update the output warning here so that if FileUpload/MultipleFileUpload are imported, warn that "As part of the react-dropzone dependency upgrade from version 9 to 14, the type of X prop has been changed to Y...." Code Editor would just get a warning about the version bump.
There was a problem hiding this comment.
Yeah that would make sense to me. Want me to do that under a followup?
thatblindgeye
force-pushed
the
iss166_dropzone
branch
from
af86416 to
78a97f4
Compare
thatblindgeye
force-pushed
the
iss166_dropzone
branch
from
78a97f4 to
73b4973
Compare
Closes #166