Skip to content

Conversation

wvanderwaal-iqmessenger

Hello,

I've added the prop wsProtocols to the VncConsole component, this array of strings allows for a specific sub-protocol in the websocket connection.

This is already part of the version of noVNC included in react-console, this can also be found in the noVNC API documentation: https://novnc.com/noVNC/docs/API.html

Since there are no unit tests that cover this part, I've just rebuild it and tested it locally, and for me it works as expected.

I didn't change the documentation part, since the prop 'credentials' is also missing from the documentation and I'm not sure if the documentation is still generated from there. If it is, and it needs to be added, I'll do so, always easier to add then to remove.

-Wouter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant