Added wsProtocols prop to VncConsole #96
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've added the prop wsProtocols to the VncConsole component, this array of strings allows for a specific sub-protocol in the websocket connection.
This is already part of the version of noVNC included in react-console, this can also be found in the noVNC API documentation: https://novnc.com/noVNC/docs/API.html
Since there are no unit tests that cover this part, I've just rebuild it and tested it locally, and for me it works as expected.
I didn't change the documentation part, since the prop 'credentials' is also missing from the documentation and I'm not sure if the documentation is still generated from there. If it is, and it needs to be added, I'll do so, always easier to add then to remove.
-Wouter