Fixes in ability to apply a dark theme only to the log viewer #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmcfaul
approved these changes
Dec 4, 2024
mcoker
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
LGTM! Though I'll mention that I think you can clean this up a little - I tested this quickly in dev tools and it seemed to work OK. You could try making changes to this block
react-log-viewer/packages/module/src/LogViewer/css/log-viewer.css
Lines 57 to 66 in 698523d
html:not(.pf-v6-theme-dark) .pf-v6-c-log-viewer.pf-m-dark {
--pf-v6-c-log-viewer__main--BorderWidth: var(--pf-v6-c-log-viewer--m-dark__main--BorderWidth);
--pf-v6-c-log-viewer__main--BackgroundColor: var(--pf-v6-c-log-viewer--m-dark__main--BackgroundColor);
--pf-v6-c-log-viewer__text--Color: var(--pf-v6-c-log-viewer--m-dark__text--Color);
--pf-v6-c-log-viewer__index--Color: var( --pf-v6-c-log-viewer--m-dark__index--Color);
}The changes are:
- Moves
--pf-v6-c-log-viewer__main--BorderWidth: var(--pf-v6-c-log-viewer--m-dark__main--BorderWidth)into the block withhtml:not(.pf-v6-theme-dark)so the border is only removed in the dark log viewer in PF's light theme. Currently in this PR the dark log viewer in PF's dark mode is removing this border, which I'm assuming we don't want - Removes
--pf-v6-c-log-viewer__main--BorderColor: var(--pf-t--global--border--color--default). That declaration is redeclaring the log viewer var with the same token value as it was originally defined, so it isn't doing anything. - Removes
--pf-v6-c-log-viewer--m-line-numbers__list--before--BackgroundColor: var(--pf-t--global--border--color--default)for the same reason as the previous bullet. - Removes
.pf-v6-c-log-viewer__mainfrom the selector for the dark theme overrides. Typically these modifications are best made at the top-level component selector (eg,.pf-v6-c-log-viewer). It isn't always possible, depending on the override, but it should work fine here.
|
🎉 This PR is included in version 6.1.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code to add the ability to always apply a dark theme to the log viewer.
https://issue82-logviewer.surge.sh