Optimize string copying in rebuffer() and stgwrite() #269
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this patch I've replaced loops with
CHECK_STGPIPE
/CHECK_STGBUFFER
checks at every iteration with a single buffer growth check and amemcpy
call.This doesn't do much performance-wise, but I think it's still good to have.
Also it seems that the same kind of optimisation has already been applied in
stgwrite
within theelse
branch, but for some reason not within theif (staging)
branch.