Skip to content

Fix empty warnings causing crashes #369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 4, 2018
Merged

Fix empty warnings causing crashes #369

merged 2 commits into from
Oct 4, 2018

Conversation

spacemud
Copy link
Contributor

@spacemud spacemud commented Oct 1, 2018 •
edited by Southclaws
Loading

What this PR does / why we need it:

  • Because I want a free T shirt. Also non crashing compilers are cool.

Which issue(s) this PR fixes:

Fixes #339

What kind of pull this is:

  • A Bug Fix
  • A New Feature
  • Some repository meta (documentation, etc)
  • Other

Additional Documentation:

@spacemud spacemud requested a review from a team as a code owner October 1, 2018 22:42
@YashasSamaga
Copy link
Member

It appears like the upstream branch for your issue-339 branch is set to master. You need to set its upstream to dev.

@Southclaws Southclaws changed the base branch from dev to master October 3, 2018 19:10
@Southclaws Southclaws changed the base branch from master to dev October 3, 2018 19:10
@Southclaws
Copy link
Collaborator

Note: I fixed dev being behind master - it was my fault for merging a change to the readme directly to master, resulting in dev being 1 commit behind. I then removed my readme commit from this PR by changing the base of a PR to master and back to dev.

@spacemud
Add tests
886d8d2 
...fix tests
@Southclaws
Copy link
Collaborator

Travis seems to have glitched out (again) and isn't running the build... but oh well :shipit:

@Southclaws Southclaws merged commit 35fa8d4 into pawn-lang:dev Oct 4, 2018
@spacemud spacemud deleted the issue-339 branch October 12, 2018 14:48
Daniel-Cortez pushed a commit to Daniel-Cortez/pawn-3.10 that referenced this pull request Jul 20, 2019
@spacemud @Daniel-Cortez
Fix empty warnings causing crashes (pawn-lang#369)
b1db897 
* Fix empty warnings causing crashes

* Add tests

...fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pr: need tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spacemud @YashasSamaga @Southclaws