Skip to content

Show symbol name with indeterminate array size warning #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 15, 2018
Merged

Show symbol name with indeterminate array size warning #370

merged 3 commits into from
Oct 15, 2018

Conversation

spacemud
Copy link
Contributor

@spacemud spacemud commented Oct 2, 2018

What this PR does / why we need it:

  • Fixes the below issue

Which issue(s) this PR fixes:

Fixes #338

What kind of pull this is:

  • A Bug Fix
  • A New Feature
  • Some repository meta (documentation, etc)
  • Other

Additional Documentation:

@spacemud spacemud requested a review from a team as a code owner October 2, 2018 19:56
@YashasSamaga
Copy link
Member

YashasSamaga commented Oct 3, 2018

The CI is failing because a test suit used previously was written to work around this bug. You'll have to update md_array_size_chk_gh_314 test.

Expected errors:
md_array_size_chk_gh_314.pwn(1) : error 009: invalid array size (negative, zero or out of bounds)
md_array_size_chk_gh_314.pwn(2) : error 009: invalid array size (negative, zero or out of bounds)
md_array_size_chk_gh_314.pwn(3) : error 009: invalid array size (negative, zero or out of bounds)
md_array_size_chk_gh_314.pwn(5) : error 009: invalid array size (negative, zero or out of bounds)
md_array_size_chk_gh_314.pwn(30) : warning 224: indeterminate array size in "sizeof" expression (symbol "")

Actual errors:
md_array_size_chk_gh_314.pwn(1) : error 009: invalid array size (negative, zero or out of bounds)
md_array_size_chk_gh_314.pwn(2) : error 009: invalid array size (negative, zero or out of bounds)
md_array_size_chk_gh_314.pwn(3) : error 009: invalid array size (negative, zero or out of bounds)
md_array_size_chk_gh_314.pwn(5) : error 009: invalid array size (negative, zero or out of bounds)
md_array_size_chk_gh_314.pwn(30) : warning 224: indeterminate array size in "sizeof" expression (symbol "arr1")

@Southclaws Southclaws merged commit 19dabbb into pawn-lang:dev Oct 15, 2018
Daniel-Cortez pushed a commit to Daniel-Cortez/pawn-3.10 that referenced this pull request Jul 20, 2019
* Show symbol name with indeterminate array size warning

* Update older test to account for bug fix

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants