fix(plugin-multi-tenant): unnecessary modal appearing #12854
Merged
+744
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
packages/plugin-multi-tenant/src/providers/TenantSelectionProvider/index.client.tsx
Outdated
Show resolved
Hide resolved
JarrodMFlesch
commented
Jun 24, 2025
packages/plugin-multi-tenant/src/providers/TenantSelectionProvider/index.client.tsx
Outdated
Show resolved
Hide resolved
|
You got a warrant for that modal? |
DanRibbens
reviewed
Jun 27, 2025
packages/plugin-multi-tenant/src/providers/TenantSelectionProvider/index.client.tsx
Outdated
Show resolved
Hide resolved
DanRibbens
previously approved these changes
Jun 27, 2025
DanRibbens
approved these changes
Jun 27, 2025
JarrodMFlesch
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12826
Leave without saving was being triggered when no changes were made to the tenant. This should only happen if the value in form state differs from that of the selected tenant, i.e. after changing tenants.
Adds tenant selector syncing so the selector updates when a tenant is added or the name is edited.
Also adds E2E for most multi-tenant admin functionality.