fix(ui): disable (or rather don't enable) form validation after draft submit error #12918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes case where submitting a document as a draft in a collection with versioning enabled would cause publishing validation errors to be displayed on further document form changes. An example case is when saving the draft failed due to a `beforeChange` hook throwing an `APIError`. The code change applies to any failing document submit where there's no field related error, but just generic errors. The behavior change is that the form state is marked as un-submitted, which in turn results in `packages/ui/src/views/Edit/index.tsx` to use `skipValidation: true`.
Removes cases where submitting a document as a draft in a collection with versioning enabled would cause publishing validation errors to be displayed on further document form changes. An example case is when saving the draft failed due to a `beforeChange` hook throwing an `APIError`. The behavior change is that the form state is marked as un-submitted post a submit failure as a draft. The form not being considered as submitted results in `packages/ui/src/views/Edit/index.tsx` to use `skipValidation: true`.
philipp-tailor
changed the title
philipp-tailor
changed the title
philipp-tailor
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #12893.
What?
Removes cases where submitting a document as a draft in a collection with versioning enabled would cause publishing validation errors to be displayed on further document form changes. An example case is when saving the draft failed due to a
beforeChangehook throwing anAPIError.How
The behavior change is that the form state is marked as un-submitted post a submit failure as a draft. The form not being considered as submitted results in
packages/ui/src/views/Edit/index.tsxto useskipValidation: true.