Skip to content

fix: appropriately throw unverified email error #12933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 27, 2025

Conversation

akhrarovsaid
Copy link
Contributor

What?

This PR addresses an issue where the order of operations/conditions for throwing an unverified email error were incorrect.

Why?

To properly throw an unverified email error under the correct conditions.

How?

Pushing this error to be thrown later in the operation.

Copy link
Contributor

@DanRibbens DanRibbens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not understanding what the issue is in the order of checks for login that we had before this code change. You might just need to add more to the PR description if there is a good reason.

@r1tsuu r1tsuu requested a review from DanRibbens June 27, 2025 19:01
@DanRibbens DanRibbens enabled auto-merge (squash) June 27, 2025 19:23
@DanRibbens DanRibbens merged commit 9f60306 into payloadcms:main Jun 27, 2025
77 checks passed
@akhrarovsaid akhrarovsaid deleted the fix/unverified-error-order branch June 27, 2025 19:40
Copy link
Contributor

github-actions bot commented Jul 3, 2025

🚀 This is included in version v3.45.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants