fix(ui): significantly more predictable autosave form state #13460
+278
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
jacobsfletch
changed the title
JarrodMFlesch
approved these changes
Aug 14, 2025
jacobsfletch
commented
Aug 14, 2025
| if ('value' in action) { | ||
| for (const [path, field] of Object.entries(newState)) { | ||
| if (path !== action.path && 'isModified' in field) { | ||
| delete newState[path].isModified |
There was a problem hiding this comment.
Note: this is not ideal, but works for now. An alternate approach would be to store the lastModifiedPath on the form context itself. That would remove this loop. The problem is we don't have access to that context from within the field reducer.
|
🚀 This is included in version v3.52.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #13416 and #13438.
Persists local state in a much more predictable way when autosave is enabled. Instead of comparing values to determine if a field was modified, we manage an
isModifiedflag in local form state. Referential comparison was an inherent problem to begin with, as form state can include JSON, etc., and it would be expensive to deeply compare values.This PR also ensures computed values aren't overwritten during autosave. Right now it is possible to enter into race conditions where the incoming form state from the server overrides any local changes that were made while the initial request was still processing.
This is especially noticeable within JSON fields, etc. which are formatted on the server. This, by default, makes them have computed values.
Here's an example:
Before:
before.mov
After:
after.mp4