-
Notifications
You must be signed in to change notification settings - Fork 3k
fix(next): custom views not overriding built-in single-segment routes #14066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
PatrikKozak
wants to merge
8
commits into
main
Choose a base branch
from
fix/allow-overriding-builtin-views
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 esbuild Bundle Analysis for payloadThis analysis was generated by esbuild-bundle-analyzer. 🤖
Largest pathsThese visualization shows top 20 largest paths in the bundle.Meta file: packages/next/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_index.json, Out file: esbuild/index.js
Meta file: packages/payload/meta_shared.json, Out file: esbuild/exports/shared.js
Meta file: packages/richtext-lexical/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_client.json, Out file: esbuild/exports/client_optimized/index.js
Meta file: packages/ui/meta_shared.json, Out file: esbuild/exports/shared_optimized/index.js
DetailsNext to the size is how much the size has increased or decreased compared with the base branch of this PR.
|
…verriding-builtin-views
paulpopus
previously approved these changes
Oct 6, 2025
…verriding-builtin-views
…ute and only fallback to re-matching by route
…verriding-builtin-views
…verriding-builtin-views
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the ability to override built-in single-segment admin views (like
create-first-user
,login
,account
, etc.) with custom views viaadmin.components.views
.Why?
Previously, when users tried to replace built-in views like
create-first-user
using the custom views configuration, the built-in view would still render. The routing logic ingetRouteData.ts
was checking for built-in views before checking for custom view overrides, making it impossible to replace them.How?
Modified the route matching logic in
getRouteData.ts
to check for custom view overrides before falling back to built-inoneSegmentViews
. When a custom view is configured with a key matching a built-in view (e.g.,'create-first-user'
), the custom view now takes precedence while preserving the correct template type and view type from the built-in configuration.Fixes #14046