Skip to content

shuffle with cython #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 11, 2021

Conversation

martindurant
Copy link

The very same code with cython! I have not tried a benchmark, but I don't see why it would perform any different; except I have not yet figured out the correct type for variable e, and have not yet turned off bounds checking and GIL.

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py39 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • GitHub Actions CI passes
  • Test coverage to 100% (Coveralls passes)

@martindurant
Copy link
Author

(sorry, added in a bunch of c files by accident, I'll revert those)

@pbranson pbranson merged commit 2db05b6 into pbranson:shufflecodec-numba Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants