Make Transaction history private

[Zishan-7]

Contributes to TASK-13200

[notion-workspace]

Make activity great (private) again!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-wallet	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 25, 2025 8:36am

[coderabbitai]

Walkthrough

The changes add a new filtering option to the useTransactionHistory hook, enabling selective retrieval of mutual transactions based on user context. The HomeHistory and PublicProfile components are updated to utilize this filter and to conditionally render transaction history and account creation prompts based on the user's login status.

Changes

File(s)	Change Summary
src/components/Home/HomeHistory.tsx	Updated to pass filterMutualTxs and enabled flags to useTransactionHistory based on user context.
src/components/Profile/components/PublicProfile.tsx	Added GIF animation and conditional "create account" prompt for guests; updated history rendering logic.
src/hooks/useTransactionHistory.ts	Extended hook options and signatures to support filterMutualTxs; updated API request and query keys accordingly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 127d74e and 2b8c707.

📒 Files selected for processing (3)

• src/components/Home/HomeHistory.tsx (1 hunks)
• src/components/Profile/components/PublicProfile.tsx (3 hunks)
• src/hooks/useTransactionHistory.ts (4 hunks)

🧰 Additional context used

🪛 Biome (2.1.2)

src/hooks/useTransactionHistory.ts

[error] 232-232: This hook is being called conditionally, but all hooks must be called in the exact same order in every component render.

For React to preserve state between calls, hooks needs to be called unconditionally and always in the same order.
See https://reactjs.org/docs/hooks-rules.html#only-call-hooks-at-the-top-level

(lint/correctness/useHookAtTopLevel)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)

• GitHub Check: Deploy-Preview
• GitHub Check: Analyze (javascript-typescript)

🔇 Additional comments (8)

src/components/Home/HomeHistory.tsx (2)

29-30: LGTM! Clean conditional filtering logic.

The conditional logic for filterMutualTxs correctly identifies when to filter mutual transactions - only when viewing another user's profile in non-public mode. This aligns with the privacy objective of the PR.

---

31-36: Good implementation of conditional data fetching.

Adding the enabled: isLoggedIn parameter ensures transaction history is only fetched for authenticated users, which supports the privacy requirements. The hook call properly passes all necessary parameters for the new filtering functionality.

src/components/Profile/components/PublicProfile.tsx (3)

19-19: LGTM! Clean asset import.

The GIF animation import follows standard practices and will enhance the user experience for guest users.

---

128-172: Excellent UX improvement for guest users.

The create account prompt with animation provides a clear call-to-action for unauthenticated users, improving conversion potential while maintaining the privacy boundaries established by hiding transaction history.

---

175-175: Confirm privacy requirement for guest transaction history

I searched for any other usages of HomeHistory isPublic={true} and found none. This change fully hides the transaction history for non-logged-in users. Please verify that this aligns with the intended behavior—i.e., guests shouldn’t see any history rather than a limited/public view. If a public or filtered version is required, update the logic accordingly.

• File: src/components/Profile/components/PublicProfile.tsx
Line 175:

{isLoggedIn && <HomeHistory isPublic={false} username={username} />}

src/hooks/useTransactionHistory.ts (3)

84-84: Well-structured type definitions for new filtering feature.

The filterMutualTxs parameter is properly typed across all function overloads, maintaining type safety while adding the new filtering capability.

Also applies to: 92-92, 111-111

---

125-126: Correct implementation of conditional query parameter.

The logic properly appends the targetUsername parameter only when both filterMutualTxs is true and username is provided, ensuring the backend receives the necessary information for mutual transaction filtering.

---

230-233: Smart cache invalidation strategy.

Including the username in the query key when filtering ensures proper cache invalidation when viewing different users' mutual transactions. This prevents stale data issues.

Note: The static analysis warning about conditional hook usage is a false positive - the useQuery hook itself is not being called conditionally, only the query key construction is conditional, which is perfectly valid.

✨ Finishing Touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch feat/private-txn-history

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai generate unit tests to generate unit tests for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.