-
Notifications
You must be signed in to change notification settings - Fork 13
Remove account management button #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Zishan-7
commented
Sep 8, 2025

WalkthroughThe Profile component hides the “Bank accounts” menu item by commenting it out and adding a note indicating it will be enabled with the Account Management project. No other structural or API changes were made. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/components/Profile/index.tsx (2)
56-63
: Prefer a feature flag over commented-out JSXUse a build-time env flag to toggle rendering instead of keeping dead code in comments.
Apply this diff within the changed block:
- {/* Enable with Account Management project. */} - {/* <ProfileMenuItem - icon="bank" - label="Bank accounts" - href="https://github.com/profile/bank-accounts" - position="middle" - comingSoon - /> */} + {/* Account Management (controlled by NEXT_PUBLIC_FEATURE_ACCOUNT_MGMT) */} + {ACCOUNT_MGMT_ENABLED && ( + <ProfileMenuItem + icon="bank" + label="Bank accounts" + href="https://github.com/profile/bank-accounts" + position="middle" + /> + )}And add the flag in this component (near other consts):
const ACCOUNT_MGMT_ENABLED = process.env.NEXT_PUBLIC_FEATURE_ACCOUNT_MGMT === 'true'
56-56
: Make the comment actionableReference a tracker/ticket so re-enabling doesn’t get lost.
- {/* Enable with Account Management project. */} + {/* TODO(ACCOUNT-MGMT-<ticket>): Enable with Account Management project. */}
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/components/Profile/index.tsx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
🔇 Additional comments (2)
src/components/Profile/index.tsx (2)
56-63
: LGTM: Bank accounts button removed as requestedCommenting out the item achieves the PR goal without affecting the rest of the group styling (“first” + “last” still render correctly with two items).
56-63
: No blocking or test updates required for bank accounts menu item
No/profile/bank-accounts
route or related UI/E2E tests were found in the codebase; no additional guards or test adjustments are needed.