-
Notifications
You must be signed in to change notification settings - Fork 13
Support page feature #1195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support page feature #1195
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughAdds /support as a recognized public path and updates auth gating to respect public paths; exposes Support entry points via a footer link, a “Talk to Support” CTA in the LandingPage security section, and a “Contact Support” button on the error page. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Pre-merge checks (1 passed, 1 warning, 1 inconclusive)❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal). Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/app/(mobile-ui)/layout.tsx
(2 hunks)src/app/[...recipient]/error.tsx
(2 hunks)src/components/LandingPage/Footer.tsx
(1 hunks)src/components/LandingPage/securityBuiltIn.tsx
(2 hunks)
🧰 Additional context used
🧬 Code graph analysis (2)
src/app/[...recipient]/error.tsx (1)
src/components/0_Bruddle/Button.tsx (1)
Button
(76-267)
src/components/LandingPage/securityBuiltIn.tsx (1)
src/components/0_Bruddle/Button.tsx (1)
Button
(76-267)
🪛 GitHub Actions: Tests
src/app/[...recipient]/error.tsx
[warning] 1-1: Prettier formatting issue detected in src/app/[...recipient]/error.tsx. Run 'prettier --write' to fix.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Deploy-Preview
🔇 Additional comments (8)
src/components/LandingPage/Footer.tsx (1)
60-62
: LGTM! Support link added successfully.The Support link is properly integrated into the footer navigation with consistent styling and appropriate linking to
/support
.src/components/LandingPage/securityBuiltIn.tsx (2)
2-2
: LGTM! Button import added correctly.The Button component import is properly added to support the new CTA functionality.
85-96
: LGTM! Well-implemented conditional CTA.The "Talk to Support" button is properly conditional to feature ID 3, uses appropriate styling, and correctly links to
/support
. The implementation is clean and follows the existing component patterns.src/app/[...recipient]/error.tsx (3)
5-5
: LGTM! Router import added for navigation.The
useRouter
import is correctly added to enable client-side navigation to the support page.
8-8
: LGTM! Router instance created properly.The router instance is correctly initialized for navigation functionality.
22-22
: LGTM! Improved layout with flex column.The Card.Content layout is enhanced with flex column and gap spacing for better visual organization of the buttons.
src/app/(mobile-ui)/layout.tsx (2)
24-25
: LGTM! Clear documentation and correct regex update.The comment clearly explains the purpose of public paths, and the regex is correctly updated to include
/support
while maintaining the existing patterns.
84-87
: LGTM! Consistent public path handling.The public path logic is properly implemented and consistently used in the authentication gating condition. The
isPublicPath
variable correctly utilizes the updated regex pattern.
Uh oh!
There was an error while loading. Please reload this page.