[TASK-12561] fix: always show the bottom border for the deposit message

[Zishan-7]

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
peanut-wallet	Ready	Preview	Comment	Sep 16, 2025 7:15am

[notion-workspace]

non-blocking bugs on/off-ramp flows

[coderabbitai]

Walkthrough

Adjusted the TransactionDetailsReceipt depositInstructions row to always show a bottom border by setting hideBottomBorder to false, replacing a previous conditional. No exported/public APIs changed.

Changes

Cohort / File(s)	Summary
TransactionDetails UI src/components/TransactionDetails/TransactionDetailsReceipt.tsx	Replaced conditional shouldHideBorder('depositInstructions') with constant false for hideBottomBorder, ensuring the Deposit Message row always renders with a bottom border. Added an explanatory comment.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• [TASK-12561] Fix on/off-ramp bugs #1215 — Also edits TransactionDetailsReceipt.tsx, modifying bank-details button font weight; touches the same component.

Suggested labels

enhancement

Suggested reviewers

• kushagrasarathe
• jjramirezn

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title "[TASK-12561] fix: always show the bottom border for the deposit message" directly and succinctly describes the main change in the diff (the depositInstructions row was changed to always show its bottom border by setting hideBottomBorder to false), so it accurately summarizes the primary intent of the PR.
Description Check	✅ Passed	The PR description contains only an attached image (a UI screenshot) which appears related to the change to the deposit message border, so under the lenient criteria this description is considered related to the changeset even though it lacks textual context.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

• 📝 Generate Docstrings

🧪 Generate unit tests

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/add-missing-bottom-border

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

• Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
• Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (2)

128-135: Guard rendering on presence of deposit_message to avoid undefined UI/copy text.

Row visibility is keyed off bank_name, but the row uses deposit_message. Gate on both to prevent rendering/copying an undefined value.

Apply this diff:

             depositInstructions: !!(
                 (transaction.extraDataForDrawer?.originalType === EHistoryEntryType.BRIDGE_ONRAMP ||
                     (isPendingBankRequest &&
                         transaction.extraDataForDrawer?.originalUserRole === EHistoryUserRole.SENDER)) &&
                 transaction.status === 'pending' &&
                 transaction.extraDataForDrawer?.depositInstructions &&
-                transaction.extraDataForDrawer.depositInstructions.bank_name
+                transaction.extraDataForDrawer.depositInstructions.bank_name &&
+                transaction.extraDataForDrawer.depositInstructions.deposit_message
             ),

---

102-102: Typo in comment.

“acitvity” → “activity”.

-                // hide token and network for send links in acitvity drawer for sender
+                // hide token and network for send links in activity drawer for sender

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34098c0 and 0d0cb47.

📒 Files selected for processing (1)

• src/components/TransactionDetails/TransactionDetailsReceipt.tsx (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: Deploy-Preview

🔇 Additional comments (1)

src/components/TransactionDetails/TransactionDetailsReceipt.tsx (1)

519-520: LGTM: border now always visible for Deposit Message row.

Matches the PR goal. Please quickly sanity‑check visuals when:

• depositInstructions is the last visible row, and
• bank details are toggled closed/open,
  in both light/dark themes.