Release (cashout release) #470

Hugo0 · 2024-10-23T08:34:51Z

temp cashout release

1600x800 is excessive for social previews 400x200 is more reasonable (still on the big side) From 3000ms to 300ms on local (only image generation)

This image does not change, so we can just use a statc asset.

Instead of having initial data and then updating it, load the data when initializing the context if preferences are found.

This will ensure we start with the intended token selector context

Bring back spinning peanutman!

[ISSUE-213] refactor: load token pair onto selector context before advancing from pay

Disable sorting

…st-links [TASK-6299] perf: improve load times for claim links social preview

[ISSUE-201] fix(token-selector): show empty message when no token match filter

vercel · 2024-10-23T08:34:56Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	🛑 Canceled (Inspect)			Oct 23, 2024 8:38am

coderabbitai · 2024-10-23T08:35:00Z

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The pull request introduces several changes across multiple files, primarily focusing on enhancing the cashout process and related functionalities. Key modifications include the addition of a temporary redirect from the root path to the cashout path, updates to dependency management, and improvements in various components to streamline user interactions and error handling. The changes also involve refining the handling of token selection and cross-chain transactions, alongside enhancements in state management and logging for better visibility during operations.

Changes

File	Change Summary
`next.config.js`	Added a temporary redirect from `/` to `/cashout`.
`package.json`	Removed dependency `@vercel/og` version `^0.6.3`.
`src/app/api/preview-image/route.tsx`	Updated import from `@vercel/og` to `next/og` and changed `ImageResponse` dimensions.
`src/app/claim/page.tsx`	Simplified `generateMetadata` function by removing `params` argument and enhanced `host` handling.
`src/components/Cashout/Components/Initial.view.tsx`	Updated label text and improved bank account validation logic with enhanced error handling.
`src/components/Global/ImageGeneration/LinkPreview.tsx`	Adjusted component layout and styling, updated dynamic URL handling for background images.
`src/components/Global/Sorting/index.tsx`	Changed button behavior to log a warning instead of toggling state; updated class name.
`src/components/Global/TokenSelector/TokenSelector.tsx`	Removed `hasFetchedBalances` variable for simplified rendering logic.
`src/components/Offramp/Confirm.view.tsx`	Enhanced cross-chain transaction handling and improved error feedback in UI.
`src/components/Request/Pay/Pay.tsx`	Added context consumption for token selection state management and updated loading state logic.
`src/components/Request/Pay/Views/Initial.view.tsx`	Added new effects for state management and error handling, improved token logo fetching logic.
`src/context/tokenSelector.context.tsx`	Updated state initialization to use `initialTokenData` for dynamic values based on user preferences.
`src/utils/cashout.utils.ts`	Enhanced error handling and logging in asynchronous functions.

Possibly related PRs

Integrate UI with request links #375: Integrates UI with request links, which may involve similar routing logic as the main PR's redirect changes.
Fix/cashout rework #388: The cashout rework includes modifications to the cashout process, which may relate to the new redirect for cashout in the main PR.
feat: add cashout navbar #396: The addition of a cashout navbar could be relevant as it may interact with the routing changes in the main PR.
fix: Change Total to You will receive to make it clear UX #427: Changes to the OfframpConfirmView may relate to the cashout process, which is also a focus of the main PR.
fix(request): allow user to connect on request pay page #449: Enhancements to the request pay page may connect with the routing logic introduced in the main PR.
[TASK-6299] perf: improve load times for claim links social preview #460: Improvements to the social preview generation may relate to the overall user experience during cashout, which is a focus of the main PR.
[ISSUE-213] refactor: load token pair onto selector context before advancing from pay #461: The refactor to load token pairs before advancing may connect with the routing logic in the main PR.
[ISSUE-201] fix(token-selector): show empty message when no token match filter #466: The fix for displaying an empty message when no tokens match could relate to the user experience improvements in the main PR.
Disable sorting #468: The changes to the OfframpConfirmView may connect with the cashout process, which is relevant to the main PR.

Suggested labels

Being worked on

Suggested reviewers

jjramirezn

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

jjramirezn and others added 16 commits October 17, 2024 16:37

build: remove deprecated @vercel/og dependency

9aab454

perf: smaller social preview images

16335f0

1600x800 is excessive for social previews 400x200 is more reasonable (still on the big side) From 3000ms to 300ms on local (only image generation)

perf: dont generate preview background everytime

bb0ddca

This image does not change, so we can just use a statc asset.

fix: 458 fixes

fd24ff3

chore: tiny log addition

1f3d423

refactor: load token pref when initializing selector context

eead963

Instead of having initial data and then updating it, load the data when initializing the context if preferences are found.

refactor(request): on pay, load the pair before advancing view

dcff4f1

This will ensure we start with the intended token selector context

fix(request): check correct state for loading

a141308

Bring back spinning peanutman!

Merge pull request #461 from peanutprotocol/fix/no-route-found-same-pair

cb65b74

[ISSUE-213] refactor: load token pair onto selector context before advancing from pay

fix(token-selector): show empty message when no token match filter

0d92623

fix: disabled sorting

7d20643

Merge pull request #468 from peanutprotocol/disable_sorting

462b880

Disable sorting

Merge pull request #460 from peanutprotocol/feat/social-preview-reque…

1882598

…st-links [TASK-6299] perf: improve load times for claim links social preview

Merge pull request #466 from peanutprotocol/fix/empty-token-selector

5c00000

[ISSUE-201] fix(token-selector): show empty message when no token match filter

fix: temp fix to redirect / to /cashout

debbc33

fix: cashout copy

03a62f7

fix: type temp fix

a256c8b

Hugo0 merged commit 0426cac into main Oct 23, 2024
1 of 2 checks passed

vercel bot temporarily deployed to Preview October 23, 2024 08:38 Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release (cashout release) #470

Release (cashout release) #470

Uh oh!

Hugo0 commented Oct 23, 2024

Uh oh!

vercel bot commented Oct 23, 2024 •

edited

Loading

Uh oh!

coderabbitai bot commented Oct 23, 2024 •

edited

Loading

Review failed

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

Release (cashout release) #470

Release (cashout release) #470

Uh oh!

Conversation

Hugo0 commented Oct 23, 2024

Uh oh!

vercel bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Oct 23, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review failed

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Oct 23, 2024 •

edited

Loading

coderabbitai bot commented Oct 23, 2024 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)