-
Notifications
You must be signed in to change notification settings - Fork 13
[ISSUE-249] fix: locked validated input #476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We were previousley checking previousValueRef.current to see if the value was the same as the debounced value. This was causing issues and is no longer necessary, because it was introduced when the state was not handled correctly
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
📝 WalkthroughWalkthroughThe changes in the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
src/components/Global/ValidatedInput/index.tsx (1)
Line range hint
36-36
: Remove unused previousValueRef update.The
previousValueRef.current
is being updated but is no longer used in the validation logic. This reference can be safely removed along with its declaration.Apply these changes:
- const previousValueRef = useRef(value)
- previousValueRef.current = debouncedValue
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
📒 Files selected for processing (1)
- src/components/Global/ValidatedInput/index.tsx (1 hunks)
🧰 Additional context used
🔇 Additional comments (2)
src/components/Global/ValidatedInput/index.tsx (2)
32-33
: LGTM! Simplified validation logic improves code clarity.The simplified check for empty value is cleaner and more maintainable. This change correctly addresses the issue mentioned in PR-249.
Line range hint
32-52
: Well-structured validation implementation.The validation logic is well-implemented with:
- Proper async operation handling
- Good error management
- Clean state updates
- Appropriate cleanup to prevent memory leaks
We were previousley checking previousValueRef.current to see if the value was the same as the debounced value. This was causing issues and is no longer necessary, because it was introduced when the state was not handled correctly