[TASK-6795] feat(request): allow attachment download on receipt #531
+60
−33
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| import Icon from '@/components/Global/Icon' | ||
|
|
||
| export const ReferenceAndAttachment = ({ | ||
| reference, | ||
| attachmentUrl, | ||
| }: { | ||
| reference?: string | null | ||
| attachmentUrl?: string | null | ||
| }) => { | ||
| if (!reference && !attachmentUrl) return null | ||
| return ( | ||
| <> | ||
| <div className={`flex w-full flex-col items-center justify-center gap-2`}> | ||
| {reference && ( | ||
| <label className="max-w-full text-h8"> | ||
| Ref: <span className="font-normal"> {reference} </span> | ||
| </label> | ||
| )} | ||
| {attachmentUrl && ( | ||
| <a | ||
| href={attachmentUrl} | ||
| download | ||
| target="_blank" | ||
| className="flex w-full cursor-pointer flex-row items-center justify-center gap-1 text-h9 font-normal text-gray-1 underline " | ||
| > | ||
| <Icon name={'download'} /> | ||
| Download attachment | ||
| </a> | ||
| )} | ||
|
Comment on lines
+19
to
+29
There was a problem hiding this comment. 🛠️ Refactor suggestion Validate attachment URL before rendering Consider adding URL validation before rendering the download link to prevent potential security issues: - {attachmentUrl && (
+ {attachmentUrl && isValidUrl(attachmentUrl) && (
<a
href={attachmentUrl}
download
target="_blank"
rel="noopener noreferrer"
aria-label="Download attachment file"
className="flex w-full cursor-pointer flex-row items-center justify-center gap-1 text-h9 font-normal text-gray-1 underline "
>
<Icon name={'download'} />
Download attachment
</a>
)}
+// Add this utility function
+const isValidUrl = (url: string): boolean => {
+ try {
+ new URL(url);
+ return true;
+ } catch {
+ console.error('Invalid attachment URL provided');
+ return false;
+ }
+};
|
||
| </div> | ||
| <div className="flex w-full border-t border-dotted border-black" /> | ||
| </> | ||
| ) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add security attributes and improve accessibility
The download link needs security attributes and accessibility improvements:
<a href={attachmentUrl} download target="_blank" + rel="noopener noreferrer" + aria-label="Download attachment file" className="flex w-full cursor-pointer flex-row items-center justify-center gap-1 text-h9 font-normal text-gray-1 underline " >📝 Committable suggestion