Fix container breaking for link input view

[kushagrasarathe]

hey @Hugo0 I overrode the max-width class for the create component since the card class was being used on other places too and fixing it directly in tailwind config declaration would affect the ui on other places too.

For reference the below two screenshots show the current fix implementation

The first screenshot shows how a normal email will look like

The second screenshot shows how it would look if the email is comparatively bigger, so it will be truncated

Thoughts?

Summary by CodeRabbit

• New Features
  • Enhanced styling for the Create component, improving visual appeal.
  • Simplified layout and structure for the CreateLinkInputView component, enhancing readability.
• Bug Fixes
  • Adjusted error message display for improved clarity.
• Chores
  • Minor adjustments to the conditional rendering for better responsiveness to different transaction types.

[vercel]

@kushagrasarathe is attempting to deploy a commit to the squirrellabs Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Walkthrough

The changes in this pull request primarily focus on styling modifications to the Create component and the CreateLinkInputView component. The max-w-lg class was added to the outer div of the Create component for improved styling, while the CreateLinkInputView component underwent layout adjustments, simplifying its JSX structure. Both components retain their original functionality, state management, and logic, with no changes to the underlying control flow or data handling.

Changes

File Path	Change Summary
src/components/Create/Create.tsx	Added max-w-lg class to outer div for styling; no changes to functionality or state management.
src/components/Create/Link/Input.view.tsx	Adjusted layout and structure of JSX; changed outer div class for simplification; improved error message display; no changes to core functionality.

Possibly related PRs

• fix: fixes and refactor in request #422: Modifications to useCreateLink.tsx for handling network switching, relevant to the Create component's transaction management.
• feat(token-selector): show default tokens for connected wallets with no balance #424: Updates in TokenSelector.tsx and Initial.view.tsx that enhance user interaction and token management related to the Create component.
• Disable sorting #468: Changes in OfframpConfirmView regarding error handling and transaction processing logic, relevant to user transactions in the Create component.
• [TASK-6944] fix: disable autocorrect on address input #532: Modifications in input handling for address fields, directly related to user input in the Create component's transaction processes.

Suggested reviewers

• jjramirezn

🐰 In a world of code so bright,
Styling changes bring delight.
With max-w-lg and classes neat,
Our components are now a treat!
Layouts shift, but logic stays,
Hopping forward in new ways! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 6c6cc04 and 3b4f92c.

📒 Files selected for processing (2)

• src/components/Create/Create.tsx (1 hunks)
• src/components/Create/Link/Input.view.tsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

• src/components/Create/Create.tsx

🔇 Additional comments (2)

src/components/Create/Link/Input.view.tsx (2)

Line range hint 268-280: LGTM! Improved spacing approach

The change from flex utilities to space utilities for vertical spacing is a good improvement:

• Simpler and more maintainable
• Preserves the same visual spacing with less code
• Properly handles text overflow in the heading

---

Line range hint 280-290: LGTM! Effectively addresses layout issues

The addition of max-w-96 with mx-auto effectively:

• Prevents layout breaking with long input text
• Maintains consistent width constraints
• Centers the content properly

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 8, 2024 10:33pm

[Hugo0]

@kushagrasarathe i think the better fix here would be to deal with the issue in the card class! In fact, I think ideally we'd move away from card being a tailwind class and have it be a react component

[Hugo0]

Imo fix should be more thorough, by moving card from tailwind class to making it a react component

[kushagrasarathe]

Imo fix should be more thorough, by moving card from tailwind class to making it a react component

hey @Hugo0, this sounds like a good idea, I'll get into this and try to structure a new reusable card component