[TASK-11760] feat: return total transacted #883

jjramirezn · 2025-05-30T15:50:06Z

No description provided.

notion-workspace · 2025-05-30T15:50:11Z

Endpoint for returning total transacted with user

vercel · 2025-05-30T15:50:12Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
peanut-ui	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 30, 2025 6:18pm

coderabbitai · 2025-05-30T15:50:14Z

"""

Walkthrough

The changes add the display of total sent and received amounts to the PublicProfile component, using new fields (totalUsdSent, totalUsdReceived) fetched from the user API. The API call now includes an authorization header with a JWT token. The UI updates conditionally render these totals for authenticated users.

Changes

Files/Paths	Change Summary
src/components/Profile/components/PublicProfile.tsx	Added state for total sent/received amounts; fetches these values from user data; updated UI to conditionally render totals in styled cards.
src/services/users.ts	Extended `ApiUser` type with `totalUsdSent` and `totalUsdReceived`; modified `getByUsername` to include `Content-Type` and `Authorization` headers in fetch request.

Possibly related PRs

feat: public profile ui #806: Introduced the initial PublicProfile component and UI structure, which is directly modified and enhanced in this PR.
"""

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between abb5199 and a5bbe2b.

📒 Files selected for processing (1)

src/components/Profile/components/PublicProfile.tsx (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/components/Profile/components/PublicProfile.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Deploy-Preview

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 3

🧹 Nitpick comments (1)

src/components/Profile/components/PublicProfile.tsx (1)
103-120: Consider component naming consistency and data consistency.

Two concerns with this implementation:

Naming inconsistency: The component is called "PublicProfile" but now contains authenticated-only content. Consider renaming or restructuring.

Data consistency: The totals are fetched for all users but only displayed for authenticated users, which could be confusing.

Consider either:

Renaming the component to reflect its mixed public/private nature

Moving the authenticated content to a separate component

Only fetching the sensitive data when the user is authenticated
 useEffect(() => {
+    // Only fetch sensitive data if user is authenticated
+    const shouldFetchTotals = !!user
+    
     usersApi.getByUsername(username)
         .then((user) => {
             if (user?.fullName) setFullName(user.fullName)
-            if (user?.totalUsdSent) setTotalSent(user.totalUsdSent)
-            if (user?.totalUsdReceived) setTotalReceived(user.totalUsdReceived)
+            if (shouldFetchTotals && user?.totalUsdSent) setTotalSent(user.totalUsdSent)
+            if (shouldFetchTotals && user?.totalUsdReceived) setTotalReceived(user.totalUsdReceived)
         })
         .catch((error) => {
             console.error('Failed to fetch user data:', error)
         })
-}, [username])
+}, [username, user])

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ba77c23 and abb5199.

📒 Files selected for processing (2)

src/components/Profile/components/PublicProfile.tsx (4 hunks)
src/services/users.ts (3 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/components/Profile/components/PublicProfile.tsx (2)

src/context/authContext.tsx (1)

useAuth (198-204)

src/utils/general.utils.ts (1)

formatExtendedNumber (997-1045)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Deploy-Preview

🔇 Additional comments (4)

src/services/users.ts (1)

28-29: LGTM: New total amount fields added appropriately.

The new string fields for tracking total USD sent and received are well-defined. Using strings for currency amounts is a good practice to avoid floating-point precision issues.

src/components/Profile/components/PublicProfile.tsx (3)

16-18: LGTM: Appropriate imports added.

The new imports for formatExtendedNumber, Card, and useAuth are correctly added and align with the new functionality.

35-37: LGTM: State variables and auth hook properly initialized.

The state variables are appropriately initialized with default values, and the useAuth hook usage follows the expected pattern.

109-115: LGTM: Proper formatting and display of total amounts.

The use of formatExtendedNumber for currency formatting is appropriate, and the Card component structure follows the established pattern with proper positioning.

src/services/users.ts

src/components/Profile/components/PublicProfile.tsx

kushagrasarathe

@jjramirezn approved, resolve coderraabit comments before merge + consider showing txn stats only wen they are > 0

feat: return total transacted

abb5199

jjramirezn requested a review from kushagrasarathe May 30, 2025 15:51

coderabbitai bot reviewed May 30, 2025

View reviewed changes

src/services/users.ts Show resolved Hide resolved

src/services/users.ts Show resolved Hide resolved

src/components/Profile/components/PublicProfile.tsx Show resolved Hide resolved

vercel bot deployed to Preview – peanut-ui May 30, 2025 16:05 View deployment

kushagrasarathe approved these changes May 30, 2025

View reviewed changes

fix: hide total sent and received if 0

a5bbe2b

vercel bot deployed to Preview – peanut-ui May 30, 2025 18:18 View deployment

jjramirezn merged commit 97bc204 into peanut-wallet-dev Jun 2, 2025
5 checks passed

jjramirezn deleted the feat/return-total-transacted branch June 2, 2025 18:44

This was referenced Jun 3, 2025

Chore/gtag #887

Closed

[TASK-11943] Sprint 94 Prod release #899

Merged

coderabbitai bot mentioned this pull request Jul 23, 2025

Make txn history private #1010

Closed

coderabbitai bot mentioned this pull request Jul 31, 2025

[TASK-12234] feat: remove totals from public profile #1049

Merged

coderabbitai bot mentioned this pull request Sep 1, 2025

[TASK-12655] Fix: hide action btns for own profile POV #1155

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[TASK-11760] feat: return total transacted #883

[TASK-11760] feat: return total transacted #883

Uh oh!

jjramirezn commented May 30, 2025

Uh oh!

notion-workspace bot commented May 30, 2025

Uh oh!

vercel bot commented May 30, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented May 30, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kushagrasarathe left a comment

Uh oh!

Uh oh!

Uh oh!

[TASK-11760] feat: return total transacted #883

[TASK-11760] feat: return total transacted #883

Uh oh!

Conversation

jjramirezn commented May 30, 2025

Uh oh!

notion-workspace bot commented May 30, 2025

Uh oh!

vercel bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented May 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kushagrasarathe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

vercel bot commented May 30, 2025 •

edited

Loading

coderabbitai bot commented May 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)