Skip to content
This repository was archived by the owner on Oct 1, 2021. It is now read-only.

Update release scripts to have modern setuptools #11

Merged
merged 1 commit into from
Sep 28, 2017

Conversation

webknjaz
Copy link
Contributor

Ref #10

@fscherf
Copy link
Contributor

fscherf commented Sep 28, 2017

ah ok. Why does it use development mode?

@webknjaz
Copy link
Contributor Author

Feel free to try removing it, it fails otherwise on my laptop, but that might be something in my env

@fscherf fscherf force-pushed the feature/tox-dpl-up-setuptools branch from 8023377 to 16d555e Compare September 28, 2017 12:44
@fscherf
Copy link
Contributor

fscherf commented Sep 28, 2017

i removed the development mode and added twine to the dependencies. it seems to work, i would merge it like this

@fscherf
Copy link
Contributor

fscherf commented Sep 28, 2017

i think we can remove the makefile when it runs in tox

@webknjaz
Copy link
Contributor Author

Sounds reasonable, feel free to do this yourself, I'm AFK now.

Also remove now obsolete Makefile

Signed-off-by: Florian Scherf <[email protected]>
@fscherf fscherf force-pushed the feature/tox-dpl-up-setuptools branch from 16d555e to 2878aaa Compare September 28, 2017 13:47
@fscherf fscherf merged commit d95ad3c into pengutronix:master Sep 28, 2017
@fscherf
Copy link
Contributor

fscherf commented Sep 28, 2017

aaaahhh got it! you have to remove the classifiers from the setup.py to make setuptools use the classifiers defined in the setup.cfg.

Thanks for your great work and patience :) i released v0.8.4.3 now, i hope you are happy with it

@webknjaz
Copy link
Contributor Author

Yeah, that inconvenience with priority of setup metadata is likely to be fixed/clarified as a result of pypa/setuptools#1150 or its followup

@webknjaz
Copy link
Contributor Author

Now this page feels complete: https://pypi.org/project/aiohttp-json-rpc

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants