Skip to content

requiresMainQueueSetup warning #9

@rangav

Description

@rangav
Contributor

Hi

Does it require main Queue or not? getting react native warning

+ (BOOL)requiresMainQueueSetup
{
    return YES;
}

Activity

pentarex

pentarex commented on Mar 10, 2018

@pentarex
Owner

Hi @rangav !
When are you getting this warning?

rangav

rangav commented on Mar 11, 2018

@rangav
ContributorAuthor

When you build the RN proj in xcode, you will see warnings in output

OR when remote js dubug enabled we will see in chrome console

pentarex

pentarex commented on Mar 11, 2018

@pentarex
Owner

facebook/react-native#17679
I guess it should return NO, The Image loader that this library is using is rewritten from RCTImageLoader (because I wanted to remove the dependencies). And somehow makes sense to be NO, because we don't want to block the app while loading the images. Anyhow its warning and its by default in the background.

I will fix it today and upload a new version, anyhow I have to add request authorisation to android :)

rangav

rangav commented on Mar 11, 2018

@rangav
ContributorAuthor

Thanks @pentarex will change to NO and will do some testing.

pentarex

pentarex commented on Mar 11, 2018

@pentarex
Owner

ok please let me know :)

rangav

rangav commented on Mar 13, 2018

@rangav
ContributorAuthor

returning NO is working.

+ (BOOL)requiresMainQueueSetup
{
    return NO;
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @pentarex@rangav

        Issue actions

          requiresMainQueueSetup warning · Issue #9 · pentarex/react-native-gallery-manager