Allow intentional unused @throws in implementations #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pepakriz can you review it? |
pepakriz
requested changes
Nov 16, 2019
|
@marcospassos I really appreciate it and I want to promote it as the biggest improvement of the 0.9.x release. |
marcospassos
force-pushed
the
allow-unused-throws
branch
from
8ad9a43 to
e57634d
Compare
|
Done and up to date with master |
|
I've also added a few more tests. |
pepakriz
reviewed
Nov 16, 2019
pepakriz
approved these changes
Nov 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for allowing unused
@throwsin implementations and fixes #17.Implementations that do not throw all possible exceptions can narrow the set of possibilities by overriding the documentation block or declaring
@throws void. However, there is a legitimate use case where it becomes necessary: one may want always to declare that a method might throw the exceptions stated in the prototype to make it future proof.