Skip to content

Gomboc Fix for #24 - tf-test #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: pepegc-patch-17
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion tf-test/main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,27 @@ data "aws_region" "current" {}

resource "aws_dynamodb_table" "test_table_a" {

deletion_protection_enabled = true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • l.9 Recommended applying Deletion Protection:
    • Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
    • CIS Critical Security Controls v8.1
Leave feedback
Please post on our discussions channel. You can provide the following reference: d464e376604756a617e8baccc5cc483f0de93c9d80f2d39c7ee5e0a0d2572966

billing_mode = "PAY_PER_REQUEST"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • l.10 Recommended applying On-Demand Capacity:
    • Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
Leave feedback
Please post on our discussions channel. You can provide the following reference: 2611ff7b5b3eae44bcc9796c834cd2d2c7935c9e97dd43e531cea620e981feb1

tags = "null"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • l.11 Recommended applying Resource Tags:
    • Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
    • CIS Critical Security Controls v8.1
Leave feedback
Please post on our discussions channel. You can provide the following reference: 411f3e36ed53e52f7e3cbaf9072767d6262fc37d250785221664e8503f0fb156

server_side_encryption {
enabled = false
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • l.13 Recommended applying Encryption At-Rest with Bespoke Service Implementation:
    • Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
Leave feedback
Please post on our discussions channel. You can provide the following reference: b0f7e9f4458edaed4cd2552dd0d3c1f1f2afaf3a233e43f01c1c0ba789462c97

}
}

resource "aws_lambda_function" "myfunction" {
tracing_config {
mode = "Active"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • l.19 Recommended applying Request Tracing:
    • Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
    • CIS Critical Security Controls v8.1
Leave feedback
Please post on our discussions channel. You can provide the following reference: 62765aecbde07930d8afdc5696a332e40096397147c55134f82a87707ef492b7

}
}

resource "aws_appsync_graphql_api" "test_api" {
authentication_type = "API_KEY"
xray_enabled = true
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • l.25 Recommended applying Request Tracing:
    • Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
    • CIS Critical Security Controls v8.1
Leave feedback
Please post on our discussions channel. You can provide the following reference: af879331249c525901eab405f59e69d22c6054f0f9210c45442068029cac615e

}

resource "aws_keyspaces_table" "mykeyspacestable" {
}
encryption_specification {
type = "AWS_OWNED_KMS_KEY"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • l.30 Recommended applying Encryption At-Rest with Provider Managed Key:
    • Gomboc Best Practices CIS Critical Security Controls v8.1 (AWS)
Leave feedback
Please post on our discussions channel. You can provide the following reference: 836e766e32572c9b826b7b6eb5f08575aaa011e2acd90073135728da07e46486

}
}